Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Error propagation for not supporting partial refund #2976

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix(core): Error propagation for not supporting partial refund #2976

merged 2 commits into from
Nov 24, 2023

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Nov 24, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In case of refund, error was not being propagated specially for "not implemented error"

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Create a payment through Prophetpay
  • Create a refund partial to the amount of the payment
  • Should throw the given error
Screenshot 2023-11-24 at 4 34 38 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak requested review from a team as code owners November 24, 2023 11:03
@Sakilmostak Sakilmostak self-assigned this Nov 24, 2023
@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 24, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 97a38a7 Nov 24, 2023
12 of 14 checks passed
@SanchithHegde SanchithHegde deleted the partial_refund_fix branch November 24, 2023 12:07
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sakilmostak @ArjunKarthik @SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan