Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): mark refund status as failure for not_implemented error from connector flows #2978

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Nov 24, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

mark refund status as failure for not_implemented error from connector flows

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Do a payment with connector prophetpay
    image

  2. Perform a partial amount refund to see a 4xx error
    image
    image

  3. Check the refund status, it should be failure
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 24, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner November 24, 2023 11:28
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Nov 24, 2023
@bernard-eugine bernard-eugine merged commit d56d805 into main Nov 24, 2023
9 of 12 checks passed
@bernard-eugine bernard-eugine deleted the handle-not-implemented-refunds-create branch November 24, 2023 12:50
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants