-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payment_methods): add support for passing card_cvc in payment_method_data object along with token #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_method_data object along with token
Chethan-rao
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
C-refactor
Category: Refactor
labels
Nov 30, 2023
Chethan-rao
force-pushed
the
move-card-cvc-to-token-data
branch
from
November 30, 2023 19:20
a5f31ae
to
7881989
Compare
Chethan-rao
force-pushed
the
move-card-cvc-to-token-data
branch
from
November 30, 2023 19:38
7881989
to
47fda3e
Compare
Chethan-rao
force-pushed
the
move-card-cvc-to-token-data
branch
from
November 30, 2023 19:39
47fda3e
to
714ab73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be deprecating the
card_cvc
field in root level later
If deprecating the field, you can mark it deprecated in the OpenAPI spec as well, then remove the field entirely on a later date.
vspecky
approved these changes
Dec 4, 2023
SanchithHegde
approved these changes
Dec 4, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR provides support for passing
card_cvc
insidepayment_method_data
object along withpayment_token
duringconfirm
call.During
/confirm
, you can pass thecard_cvc
either in the root level of request or inpayment_method_data
as belowWe'll be deprecating the
card_cvc
field in root level laterAdditional Changes
Motivation and Context
How did you test it?
list_customer_payment_method
api to get thepayment_token
for the card saved due to above request.card_cvc
either in root level or inpayment_method_data
as belowFor testing purpose, i logged the
card_cvc
passedChecklist
cargo +nightly fmt --all
cargo clippy