Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pm_list): [Trustpay]Update dynamic fields for trustpay blik #3042

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Dec 4, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fix display name for trustpay blik. Instead of Billing_first_name, we were passing "cardholder_name" as display name.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Test cases - Make a confirm false call, and make "list pm for merchant" call, in required fields, updated fields such as Billing first name, last name, its display name should be Billing first name and last name.
Screenshot 2023-12-01 at 8 07 36 PM
Screenshot 2023-12-01 at 8 07 45 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Dec 4, 2023
@prasunna09 prasunna09 self-assigned this Dec 4, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner December 4, 2023 06:42
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 9274cef Dec 4, 2023
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the fix-blik-dynamic-fields-for-trustpay branch December 4, 2023 12:32
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants