feat(constraint_graph): make the constraint graph framework generic and move it into a separate crate #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd move it into a separate crate
vspecky
added
C-feature
Aprabhat19
previously approved these changes
Dec 8, 2023
2 tasks
Narayanbhat166
previously approved these changes
Dec 11, 2023
…s opposed to nodes
…aint-graphs-generic
vspecky
dismissed stale reviews from prajjwalkumar17, Aprabhat19, and Narayanbhat166
via
393c34f
…rswitch_constraint_graph
jarnura
previously approved these changes
May 2, 2024
jarnura
approved these changes
May 3, 2024
Aprabhat19
approved these changes
May 6, 2024
SanchithHegde
approved these changes
May 6, 2024
Comment on lines
+1
to
+6
| [package] | ||
| name = "hyperswitch_constraint_graph" | ||
| description = "Constraint Graph Framework for modeling Domain-Specific Constraints" | ||
| version = "0.1.0" | ||
| edition.workspace = true | ||
| rust-version.workspace = true |
There was a problem hiding this comment.
Can we add a license and optionally, a readme field?
There was a problem hiding this comment.
Will add the PR to the merge queue as @vspecky confirmed to add the license and readme in the next upcoming PR.
SanchithHegde
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR separates out and refactors the Euclid Knowledge Graph into the Constraint Graph in its own crate, and makes the Constraint Graph generic so it can work on custom key and value types as opposed to just the Euclid Key and Value types.
This will remove the dependency on Euclid when one needs to only use the Constraint Graph, plus the now generic nature of Constraint Graphs will allow them to be utilized for varied use cases other than routing.
Additional Changes
Motivation and Context
Making the constraint graph generic opens up the opportunity for other developers to adapt and use the constraint graph for their own usecases. There are many validation use cases currently in Hyperswitch that can be fulfilled by using Constraint Graphs, including but not limited to Connector domain validations, required field selection, etc.
How did you test it?
Unit tests for the
euclidandkgraph_utilscrates. No specific API tests required.Euclid:
Kgraph_utils:
Checklist
cargo +nightly fmt --allcargo clippy