feat(core): enable surcharge support for all connectors #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-feature
Narayanbhat166
previously approved these changes
Dec 12, 2023
Narayanbhat166
approved these changes
Dec 13, 2023
sai-harsha-vardhan
approved these changes
Dec 13, 2023
| pub fn get_total_amount(&self) -> i64 { | ||
| self.amount + self.surcharge_amount.unwrap_or(0) + self.tax_amount.unwrap_or(0) | ||
| } | ||
| pub fn get_total_surcharge_amount(&self) -> Option<i64> { |
There was a problem hiding this comment.
Why can't this method return i64 instead of option, However we are always using unwrap_or(0) on the results of this method
There was a problem hiding this comment.
Purpose of this method is to return total surcharge amount only if surcharge is present in payment_attempt. Otherwise None.
| @@ -178,6 +178,8 @@ impl MultipleCaptureData { | |||
|
|
|||
| #[derive(Clone, Debug, serde::Deserialize, serde::Serialize)] | |||
| pub struct SurchargeDetails { | |||
| /// original_amount | |||
| pub original_amount: i64, | |||
There was a problem hiding this comment.
Shall we rename this to payment amount instead of original_amount?
There was a problem hiding this comment.
There is another field in this struct called final_amount. The idea was final_amount = original_amount + surcharge_amount + tax_on_surcharge_amount.
So final_amount is treated as payment_amount.
Wouldn't changing original_amount to payment_amount be contradicting?
ArjunKarthik
approved these changes
Dec 14, 2023
lsampras
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Bring support for surcharge feature for all connector by handling all surcharge_amount related calculation at core and send the final amount to connector side.
Also remove connector surcharge_validation check in decide_flows() of authorize flow.
Additional Changes
Motivation and Context
How did you test it?
Manual
Surcharge on stripe
Checklist
cargo +nightly fmt --allcargo clippy