Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payments): add outgoing payments webhooks #3133

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat(payments): add outgoing payments webhooks #3133

merged 1 commit into from
Dec 14, 2023

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • New feature

Description

Add outgoing webhook when payment suceedes or fails.

Motivation and Context

To inform the merchant / upstream about payment status asynchronously

How did you test it?

  • Create a payment -> succeedes -> check whether a webhook was received on webhook site.
Screenshot 2023-12-14 at 2 43 56 PM

Screenshot 2023-12-14 at 2 44 14 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added A-core Area: Core flows C-feature Category: Feature request or enhancement labels Dec 14, 2023
@Narayanbhat166 Narayanbhat166 added this to the December 2023 Release milestone Dec 14, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this Dec 14, 2023
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner December 14, 2023 09:14
@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit f457846 Dec 14, 2023
12 of 14 checks passed
@SanchithHegde SanchithHegde deleted the add_payment_outgoing_webhooks branch December 14, 2023 11:36
lsampras pushed a commit that referenced this pull request Dec 15, 2023
@Narayanbhat166 @lsampras
feat(payments): add outgoing payments webhooks (#3133)
fab5955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@vspecky vspecky vspecky approved these changes

Assignees

@Narayanbhat166 Narayanbhat166

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Narayanbhat166 @SanchithHegde @vspecky