feat(connector): [NMI] Implement 3DS for Cards #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
ArjunKarthik
requested changes
Dec 16, 2023
| @@ -1479,6 +1479,13 @@ where | |||
| let is_error_in_response = router_data.response.is_err(); | |||
| // If is_error_in_response is true, should_continue_payment should be false, we should throw the error | |||
| (router_data, !is_error_in_response) | |||
| } else if connector.connector_name == router_types::Connector::Nmi | |||
| && !matches!(format!("{operation:?}").as_str(), "CompleteAuthorize") | |||
There was a problem hiding this comment.
Only in case of Payment Confirm we need to trigger Preprocessing
There was a problem hiding this comment.
preprocessing_steps is only implemented for authorize and complete auth flow meaning only these two flow can execute preprocessing. if it matches complete auth flow, it wont enter the body since it is a not operation, leaving only auth flow to enter this body.
Comment on lines
121
to
124
| _ => Err(errors::ConnectorError::NotSupported { | ||
| message: utils::SELECTED_PAYMENT_METHOD.to_string(), | ||
| connector: "nmi", | ||
| }) |
There was a problem hiding this comment.
Suggested change
| _ => Err(errors::ConnectorError::NotSupported { | |
| message: utils::SELECTED_PAYMENT_METHOD.to_string(), | |
| connector: "nmi", | |
| }) | |
| _ => Err(errors::ConnectorError::NotImplemented( | |
| utils::get_unimplemented_payment_method_error_message("Nmi"), | |
| )) |
| let three_ds_data: NmiRedirectResponseData = serde_json::from_value(payload_data) | ||
| .into_report() | ||
| .change_context(errors::ConnectorError::MissingConnectorRedirectionPayload { | ||
| field_name: "cavv", |
There was a problem hiding this comment.
change "cavv" to "three_ds_data" as cavv is one of the param inside three_ds_data
ArjunKarthik
approved these changes
Dec 17, 2023
deepanshu-iiitu
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The flow use:
Additional Changes
Motivation and Context
How did you test it?
No testing can be done since 3DS is not enabled in test account
Checklist
cargo +nightly fmt --allcargo clippy