Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): make the billing country for apple pay as optional field #3188

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Dec 21, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pr contains the changes to make the billing country for apple pay as optional field. In this case if a billing country is not passed in the payments create call the session call would still be done and the billing country would be collected form sdk during the payments confirm.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image image

Test Case :-
This flow needs to be tested for stripe (Manual and simplified flow), trustpay, bluesanp, payme and any important connectors for which apple pay is implemented.

  1. Create a apple pay payment with confirm false without apple the country in billing address
  2. Make a Session token call. Expected behaviour is response should contain session token for apple pay with the country_code as null.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Dec 21, 2023
@ShankarSinghC ShankarSinghC added this to the December 2023 Release milestone Dec 21, 2023
@ShankarSinghC ShankarSinghC self-assigned this Dec 21, 2023
@ShankarSinghC ShankarSinghC requested review from a team as code owners December 21, 2023 10:57
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 15987cc Dec 21, 2023
24 of 26 checks passed
@Gnanasundari24 Gnanasundari24 deleted the apayt/country-code-change branch December 21, 2023 13:10
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 25, 2023
@prajjwalkumar17 prajjwalkumar17 mentioned this pull request Jan 24, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants