-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address Rust 1.75 clippy lints #3231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
A-dependencies
Area: Dependencies
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jan 3, 2024
Chethan-rao
force-pushed
the
update-rust-1.75
branch
from
January 3, 2024 11:30
6f82412
to
30553d0
Compare
Chethan-rao
force-pushed
the
update-rust-1.75
branch
from
January 3, 2024 11:30
30553d0
to
f4c15dd
Compare
SanchithHegde
previously approved these changes
Jan 3, 2024
SanchithHegde
previously approved these changes
Jan 4, 2024
prajjwalkumar17
previously approved these changes
Jan 4, 2024
pixincreate
previously approved these changes
Jan 5, 2024
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 5, 2024
SanchithHegde
added
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 5, 2024
vspecky
previously approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks. Feel free to ignore these. LGTM otherwise.
Chethan-rao
dismissed stale reviews from vspecky, pixincreate, prajjwalkumar17, and SanchithHegde
via
January 5, 2024 08:13
24e2171
SanchithHegde
approved these changes
Jan 5, 2024
vspecky
approved these changes
Jan 5, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 7, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 8, 2024
* 'main' of github.com:juspay/hyperswitch: fix(connector): [Stripe] Deserialization Error while parsing Dispute Webhook Body (#3256) refactor(euclid_wasm): Update wasm config (#3222) fix(analytics): added response to the connector outgoing event (#3129) fix(analytics): fixed response code to 501 (#3119) fix(connector): [NMI] Populating `ErrorResponse` with required fields and Mapping `connector_response_reference_id` (#3214) feat(merchant_account): Add list multiple merchants in `MerchantAccountInterface` (#3220) feat: include version number in response headers and on application startup (#3045) chore: address Rust 1.75 clippy lints (#3231) feat: add deep health check (#3210) feat(analytics): adding outgoing webhooks kafka event (#3140) refactor: address panics due to indexing and slicing (#3233) fix(users): Fix wrong redirection url in magic link (#3217) fix(user): add integration_completed enum in metadata type (#3245) chore(version): v1.106.1 fix(connector): [iatapay] change refund amount (#3244) chore(version): v1.106.0 test(postman): update postman collection files fix(core): fix recurring mandates flow for cyber source (#3224) chore: fix channel handling for consumer workflow loop (#3223)
deepanshu-iiitu
pushed a commit
that referenced
this pull request
Jan 11, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR addresses the clippy lints occurring due to new rust version 1.75
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy