Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address Rust 1.75 clippy lints #3231

Merged
merged 9 commits into from
Jan 5, 2024
Merged

chore: address Rust 1.75 clippy lints #3231

merged 9 commits into from
Jan 5, 2024

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Jan 3, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR addresses the clippy lints occurring due to new rust version 1.75

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added A-dependencies Area: Dependencies S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 3, 2024
@Chethan-rao Chethan-rao self-assigned this Jan 3, 2024
@Chethan-rao Chethan-rao requested review from a team as code owners January 3, 2024 10:25
SanchithHegde
SanchithHegde previously approved these changes Jan 3, 2024
SanchithHegde
SanchithHegde previously approved these changes Jan 4, 2024
@Chethan-rao Chethan-rao requested a review from vspecky January 4, 2024 17:34
prajjwalkumar17
prajjwalkumar17 previously approved these changes Jan 4, 2024
@pixincreate pixincreate added this pull request to the merge queue Jan 5, 2024
@pixincreate pixincreate removed this pull request from the merge queue due to a manual request Jan 5, 2024
pixincreate
pixincreate previously approved these changes Jan 5, 2024
@pixincreate pixincreate added this pull request to the merge queue Jan 5, 2024
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 5, 2024
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request Jan 5, 2024
@SanchithHegde SanchithHegde added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 5, 2024
vspecky
vspecky previously approved these changes Jan 5, 2024
Copy link
Member

@vspecky vspecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks. Feel free to ignore these. LGTM otherwise.

crates/common_utils/src/request.rs Outdated Show resolved Hide resolved
crates/router/src/connector/checkout/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Show resolved Hide resolved
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit c8279b1 Jan 5, 2024
9 of 11 checks passed
@likhinbopanna likhinbopanna deleted the update-rust-1.75 branch January 5, 2024 11:07
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 7, 2024
pixincreate added a commit that referenced this pull request Jan 8, 2024
* 'main' of github.com:juspay/hyperswitch:
  fix(connector): [Stripe] Deserialization Error while parsing Dispute Webhook Body (#3256)
  refactor(euclid_wasm): Update wasm config (#3222)
  fix(analytics): added response to the connector outgoing event (#3129)
  fix(analytics): fixed response code to 501 (#3119)
  fix(connector): [NMI] Populating `ErrorResponse` with required fields and Mapping `connector_response_reference_id` (#3214)
  feat(merchant_account): Add list multiple merchants in `MerchantAccountInterface` (#3220)
  feat: include version number in response headers and on application startup (#3045)
  chore: address Rust 1.75 clippy lints (#3231)
  feat: add deep health check (#3210)
  feat(analytics): adding outgoing webhooks kafka event (#3140)
  refactor: address panics due to indexing and slicing (#3233)
  fix(users): Fix wrong redirection url in magic link (#3217)
  fix(user): add integration_completed enum in metadata type (#3245)
  chore(version): v1.106.1
  fix(connector): [iatapay] change refund amount (#3244)
  chore(version): v1.106.0
  test(postman): update postman collection files
  fix(core): fix recurring mandates flow for cyber source (#3224)
  chore: fix channel handling for consumer workflow loop (#3223)
deepanshu-iiitu pushed a commit that referenced this pull request Jan 11, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants