fix: update amount_capturable based on intent_status and payment flow #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-bug
Narayanbhat166
previously approved these changes
Jan 8, 2024
ArjunKarthik
requested changes
Jan 9, 2024
hrithikesh026
changed the title
jarnura
previously approved these changes
Jan 10, 2024
ArjunKarthik
requested changes
Jan 10, 2024
jarnura
approved these changes
Jan 10, 2024
Narayanbhat166
approved these changes
Jan 11, 2024
ArjunKarthik
approved these changes
Jan 11, 2024
Gnanasundari24
deleted the
update-amount_capturable-based-on-intent_status
branch
pixincreate
added a commit
that referenced
this pull request
Jan 12, 2024
…-router * 'main' of github.com:juspay/hyperswitch: (84 commits) chore(config): add merchant_secret config for webhooks for cashtocode and volt in wasm dashboard (#3333) chore(version): 2024.01.12.0 fix: update amount_capturable based on intent_status and payment flow (#3278) feat: add support for card extended bin in payment attempt (#3312) feat(connector): [cybersource] Implement 3DS flow for cards (#3290) chore: remove connector auth TOML files from `.gitignore` and `.dockerignore` (#3330) fix(refund): add merchant_connector_id in refund (#3303) feat(connector): [BOA/CYB] Store AVS response in connector_metadata (#3271) feat(outgoingwebhookevent): adding api for query to fetch outgoing webhook events log (#3310) feat(router): payment_method block (#3056) feat(connector): [Volt] Add support for refund webhooks (#3326) feat(users): invite user without email (#3328) feat(euclid_wasm): config changes for NMI (#3329) refactor(router): restricted list payment method Customer to api-key based (#3100) feat(connector): [BOA/Cyb] Include merchant metadata in capture and void requests (#3308) fix(router): add config to avoid connector tokenization for `apple pay` `simplified flow` (#3234) refactor(router): flagged order_details validation to skip validation (#3116) fix(core): surcharge with saved card failure (#3318) feat(payment_link): Added sdk layout option payment link (#3207) chore(version): 2024.01.11.0 ...
pixincreate
added a commit
that referenced
this pull request
Jan 13, 2024
* 'main' of github.com:juspay/hyperswitch: (22 commits) chore(version): 2024.01.12.1 chore: add api reference for blocklist (#3336) chore(config): add merchant_secret config for webhooks for cashtocode and volt in wasm dashboard (#3333) chore(version): 2024.01.12.0 fix: update amount_capturable based on intent_status and payment flow (#3278) feat: add support for card extended bin in payment attempt (#3312) feat(connector): [cybersource] Implement 3DS flow for cards (#3290) chore: remove connector auth TOML files from `.gitignore` and `.dockerignore` (#3330) fix(refund): add merchant_connector_id in refund (#3303) feat(connector): [BOA/CYB] Store AVS response in connector_metadata (#3271) feat(outgoingwebhookevent): adding api for query to fetch outgoing webhook events log (#3310) feat(router): payment_method block (#3056) feat(connector): [Volt] Add support for refund webhooks (#3326) feat(users): invite user without email (#3328) feat(euclid_wasm): config changes for NMI (#3329) refactor(router): restricted list payment method Customer to api-key based (#3100) feat(connector): [BOA/Cyb] Include merchant metadata in capture and void requests (#3308) fix(router): add config to avoid connector tokenization for `apple pay` `simplified flow` (#3234) refactor(router): flagged order_details validation to skip validation (#3116) fix(core): surcharge with saved card failure (#3318) ...
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
wrote logic to update amount_capturable based intent_status and payment flow.
Additional Changes
Motivation and Context
This was necessary because connector may send processing status in the authorization response (amount_capturable will be set to 0). This will later change to requires_capture when force sync is done. At this point, with the existing implementation, amount_capturable will remain 0 and will not be updated to authorized_amount. This prevents the capture of the payment. (NMI connector).
How did you test it?
Manual
Create a payment with manual capture
Force sync
Capture the payment
Force sync
Checklist
cargo +nightly fmt --allcargo clippy