Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [bluesnap] add connector_txn_id fallback for webhook #3317

Merged
merged 2 commits into from
Jan 10, 2024
Merged

refactor(connector): [bluesnap] add connector_txn_id fallback for webhook #3317

merged 2 commits into from
Jan 10, 2024

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Jan 10, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add connector_txn_id fallback for webhook

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#3316

Main PR : #3315

How did you test it?

Trigger webhooks from Bluesnap with and without merchant_transaction_id and receive outgoing webhooks from Hyperswitch

Screenshot 2024-01-10 at 7 13 24 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Jan 10, 2024
@SamraatBansal SamraatBansal self-assigned this Jan 10, 2024
@SamraatBansal SamraatBansal requested a review from a team as a code owner January 10, 2024 13:52
@likhinbopanna likhinbopanna changed the title refactor(connector): [bluesnap] add connector_transaction_id as fallback for webhooks refactor(connector): [bluesnap] add connector_txn_id as fallback for webhooks Jan 10, 2024
@likhinbopanna likhinbopanna changed the title refactor(connector): [bluesnap] add connector_txn_id as fallback for webhooks refactor(connector): [bluesnap] add connector_txn_id fallback for webhook Jan 10, 2024
@likhinbopanna likhinbopanna merged commit 833ee62 into hotfix-1.105.0 Jan 10, 2024
16 of 21 checks passed
@likhinbopanna likhinbopanna deleted the fix-bluesnap-dispute branch January 10, 2024 14:54
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 10, 2024
@SanchithHegde SanchithHegde removed the P-high Priority: High label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamraatBansal @sai-harsha-vardhan @srujanchikke @SanchithHegde @likhinbopanna