Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_link): segregated payment link in html css js files, sdk over flow issue, surcharge bug, block SPM customer call for payment link #3410

Merged
merged 23 commits into from
Jan 30, 2024
Merged

refactor(payment_link): segregated payment link in html css js files, sdk over flow issue, surcharge bug, block SPM customer call for payment link #3410

merged 23 commits into from
Jan 30, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Jan 21, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This Pr solves multiple issues related to payment_link

  1. Hosted payment_link default images to s3 and fetched the same
  2. sdk over flow issue solved for different sdk layouts
  3. Surcharge flow bug showing wrong amount in status page solved
  4. added new api endpoint to display status.html
  5. segregated single file payment_link.html to payment_link.html, payment_link.css and payment_link.js
  6. Blocked SPM customer call from sdk incase of payment links

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Flows to be tested :

  1. sdk over flow issue solved for different sdk layouts
Screenshot 2024-01-30 at 3 13 41 PM
  1. Surcharge flow bug showing wrong amount in status page solved
Screenshot 2024-01-30 at 3 14 44 PM Screenshot 2024-01-30 at 3 14 58 PM
  1. Blocked SPM customer call from sdk incase of payment links
Screenshot 2024-01-30 at 3 17 32 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal requested review from a team as code owners January 21, 2024 13:38
hyperswitch-bot bot and others added 13 commits January 21, 2024 13:38
@hyperswitch-bot
chore: run formatter
aedbb81
@kashif-m
Merge branch 'payment-link-restructuring-surcharge-flow-fixed', remot…
5f32102 
…e-tracking branch 'origin' into payment_link_updates
@kashif-m
refactor(payment_link): segregate payment widget and payment status s…
a09a40a 
…creens into different endpoints
@kashif-m
Merge remote-tracking branch 'origin/main' into payment_link_updates
2672bf6
@kashif-m
refactor(payment_link): modify redirect conditions
826bf33
@sahkal
Merge branch 'main' of https://github.com/juspay/hyperswitch into pay…
aede837 
…ment_link_updates
@kashif-m
fix(payment_link): redirect to /status during payment for merchant re…
ed8286d 
…direction
@kashif-m
refactor(payment_link): update status field consumption for status sc…
0b31c07 
…reen
@sahkal
Merge branch 'payment_link_updates' of https://github.com/juspay/hype…
b08f1be 
…rswitch into payment_link_updates
@sahkal
refactor(payment_link): fixed surcharge bug
89db8fd
@hyperswitch-bot
chore: run formatter
ea7d908
@sahkal
fix(payment_link): fixed surcharge, over-flow sdk issue, blocked SPM …
de99a4f 
…customer call, segreated code for js, css and html for easier development
@sahkal
Merge branch 'payment-link-restructuring-surcharge-flow-fixed' of htt…
260f185 
…ps://github.com/juspay/hyperswitch into payment-link-restructuring-surcharge-flow-fixed
@sahkal sahkal self-assigned this Jan 25, 2024
@sahkal sahkal added C-refactor Category: Refactor C-bug Category: Bug A-core Area: Core flows C-tracking-issue Category: Tracking issue for a proposal or a category of bugs labels Jan 25, 2024
@sahkal sahkal added this to the December 2023 Release milestone Jan 25, 2024
@sahkal sahkal changed the title refactor(payment_link): segregated payment link in html css js files refactor(payment_link): segregated payment link in html css js files, sdk over flow issue, surcharge bug, block SPM customer call for payment link Jan 25, 2024
@Narayanbhat166 Narayanbhat166 removed the C-tracking-issue Category: Tracking issue for a proposal or a category of bugs label Jan 29, 2024
@sahkal sahkal requested a review from Narayanbhat166 January 29, 2024 10:22
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 29, 2024
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 29, 2024
View reviewed changes
@sahkal sahkal requested a review from Narayanbhat166 January 29, 2024 12:56
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit a7bc8c6 Jan 30, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the payment-link-restructuring-surcharge-flow-fixed branch January 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@sahkal sahkal

Labels
A-core Area: Core flows C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sahkal @Narayanbhat166 @sai-harsha-vardhan @Gnanasundari24 @kashif-m