-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Add column mandate_data for storing the details of a mandate in PaymentAttempt #3606
Conversation
@@ -0,0 +1,3 @@ | |||
-- Your SQL goes here | |||
ALTER TABLE payment_attempt | |||
ADD COLUMN IF NOT EXISTS mandate_data JSONB DEFAULT NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADD COLUMN IF NOT EXISTS mandate_data JSONB DEFAULT NULL | |
ADD COLUMN IF NOT EXISTS mandate_data JSONB DEFAULT NULL; |
@@ -0,0 +1,2 @@ | |||
-- This file should undo anything in `up.sql` | |||
ALTER TABLE payment_attempt DROP COLUMN IF EXISTS mandate_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALTER TABLE payment_attempt DROP COLUMN IF EXISTS mandate_data | |
ALTER TABLE payment_attempt DROP COLUMN IF EXISTS mandate_data; |
…rswitch into add-colum-for-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes seems fine.
Type of Change
Description
To make the mandate_details forward compatible , instead of storing update mandate id in mandate details we store it in the new column mandate data. Currently in mandate_data column we only store update_mandate_id
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy