Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add delete_evidence api for disputes #3608

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Feb 9, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add delete_evidence api for disputes

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Create a dispute through checkout connector with dispute_opened status (docs)

  2. Add multiple evidences to the dispute using attach_evidence API
    image
    image

  3. Check dispute record in DB for entries (Alternatively can call retrieve_evidence API)
    image

  4. Call the delete_evidence API to delete a particular evidence type for a dispute
    image

  5. Check in DB if that evidence type is deleted and others are not changed (Alternatively can call retrieve_evidence API)
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 9, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Feb 9, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners February 9, 2024 06:08
@Narayanbhat166
Copy link
Member

are we not deleting the evidence file from the source?

@sai-harsha-vardhan
Copy link
Contributor Author

are we not deleting the evidence file from the source?

@Narayanbhat166 There are no Delete File APIs with connectors (stripe, checkout etc.). So, we are just deleting the mapping, and while submitting evidence we send only which are not deleted.

@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 1dc660f Feb 12, 2024
14 of 18 checks passed
@likhinbopanna likhinbopanna deleted the add-delete-dispute-evidence-api branch February 12, 2024 08:31
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants