-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payment_link): add Miscellaneous charges in cart #3645
Merged
preetamrevankar
merged 4 commits into
main
from
add-miscellaneous-expenses-payment-link-ui
Feb 28, 2024
Merged
refactor(payment_link): add Miscellaneous charges in cart #3645
preetamrevankar
merged 4 commits into
main
from
add-miscellaneous-expenses-payment-link-ui
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahkal
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Feb 13, 2024
kashif-m
reviewed
Feb 28, 2024
crates/router/src/core/payment_link/payment_link_initiate/payment_link.js
Show resolved
Hide resolved
kashif-m
previously approved these changes
Feb 28, 2024
kashif-m
approved these changes
Feb 28, 2024
sahkal
changed the title
refactor(payment_link): added Miscellaneous charges in cart
refactor(payment_link): add Miscellaneous charges in cart
Feb 28, 2024
sai-harsha-vardhan
approved these changes
Feb 28, 2024
preetamrevankar
deleted the
add-miscellaneous-expenses-payment-link-ui
branch
February 28, 2024 09:29
pixincreate
added a commit
that referenced
this pull request
Feb 29, 2024
…stman-runner * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.02.29.0 chore(postman): update Postman collection files feat(analytics): add force retrieve call for force retrieve calls (#3565) refactor(connector): [Mollie] Mask PII data (#3856) refactor(connector): [Gocardless] Mask PII data (#3844) feat(analytics): adding metric api for dispute analytics (#3810) feat(payment_methods): Add default payment method column in customers table and last used column in payment_methods table (#3790) fix(tests/postman/adyen): enable sepa payment method type for payout flows (#3861) feat(payouts): Implement Smart Retries for Payout (#3580) refactor(payment_link): add Miscellaneous charges in cart (#3645)
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added Miscellaneous charges in cart
Additional Changes
Motivation and Context
How did you test it?
Do Payment Create using the below curl, and look for Miscellaneous charges which must include the (amount - sum of all the order_details product charges).
Checklist
cargo +nightly fmt --all
cargo clippy