Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): Add audit events scaffolding #3863

Merged
merged 16 commits into from
Mar 18, 2024
Merged

feat(events): Add audit events scaffolding #3863

merged 16 commits into from
Mar 18, 2024

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Feb 28, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add support for generating audit events
  • Add traits for extending audit event generation
  • update PaymentData struct to record changes made to payment data

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • record payment events/updates for auditing

How did you test it?

  • on starting up of the server can check for audit topic log line (search grafana for line contains audit_events_topic)
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras self-assigned this Feb 28, 2024
@lsampras lsampras requested review from a team as code owners February 28, 2024 09:37
@jarnura jarnura requested a review from Gnanasundari24 March 5, 2024 09:59
@lsampras lsampras linked an issue Mar 14, 2024 that may be closed by this pull request
feat(events): create a framework for emitting events & capture audit/lifecycle events from application #4088
Closed
SanchithHegde
SanchithHegde reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

config/config.example.toml Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 6f67985 Mar 18, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the create-payment-lifecycle-events branch March 18, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivanshMathurJuspay ShivanshMathurJuspay ShivanshMathurJuspay approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@Gnanasundari24 Gnanasundari24 Awaiting requested review from Gnanasundari24

Assignees

@lsampras lsampras

Labels
A-Analytics A-framework Area: Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(events): create a framework for emitting events & capture audit/lifecycle events from application
5 participants
@lsampras @ArjunKarthik @SanchithHegde @ShivanshMathurJuspay @Gnanasundari24