-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): updated payments response with payment_method_id & payment_method_status #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajjwalkumar17
changed the title
refactor(core): updated payment's response with payment_method_id
refactor(core): updated payment's response with 'payment_method_id' & 'payment_method_status'
Mar 1, 2024
prajjwalkumar17
changed the title
refactor(core): updated payment's response with 'payment_method_id' & 'payment_method_status'
refactor(core): updated payment's response with payment_method_id & payment_method_status
Mar 1, 2024
vspecky
previously approved these changes
Mar 8, 2024
apoorvdixit88
previously approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes are ok
Narayanbhat166
previously approved these changes
Mar 8, 2024
srujanchikke
previously approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed connector code!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 10, 2024
SanchithHegde
changed the title
refactor(core): updated payment's response with payment_method_id & payment_method_status
refactor(core): updated payments response with payment_method_id & payment_method_status
Mar 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 10, 2024
prajjwalkumar17
dismissed stale reviews from srujanchikke, apoorvdixit88, Narayanbhat166, and vspecky
via
March 10, 2024 15:25
2f633dd
prajjwalkumar17
requested review from
vspecky,
Narayanbhat166,
srujanchikke and
apoorvdixit88
March 10, 2024 15:25
apoorvdixit88
approved these changes
Mar 10, 2024
srujanchikke
approved these changes
Mar 10, 2024
vspecky
approved these changes
Mar 11, 2024
Narayanbhat166
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This change incorporates every payment's response with 2 additional fields namely:
->
payment_method_id
->
payment_method_status
Additional Changes
Motivation and Context
The change will provide more context about the
payment_method
being used to carry out the payment.How did you test it?
We will have
payment_method_id
andpayment_method_status
in every payment's response(except Create).Sample curl:
Payment
done using token:Payment's Confirm
Response should include these two fields
(This will be updated after @vspecky PR linking issue here)
Payment
done using Payment Data & Customer Acceptance:Payment's Confirm
Response should include these two fields null as we are doing the operation of saving card in tokio spawn.
Checklist
cargo +nightly fmt --all
cargo clippy