feat(core): confirm flow and authorization api changes for external authentication #4015
Conversation
…odules-for-external-authn
…odules-for-external-authn
hrithikesh026
added
C-feature
| } | ||
|
|
||
| fn get_payment_action(&self) -> services::PaymentAction { | ||
| services::PaymentAction::CompleteAuthorize |
There was a problem hiding this comment.
we can maybe add a separate variant for this use case?
There was a problem hiding this comment.
This will fixed in the upcoming refactor PR.
| authentication::perform_post_authentication( | ||
| state, | ||
| authentication_connector_name.clone(), | ||
| business_profile.clone(), | ||
| authentication_connector_mca, | ||
| authentication::types::PostAuthenthenticationFlowInput::PaymentAuthNFlow { | ||
| payment_data, | ||
| authentication_data, | ||
| should_continue_confirm_transaction, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
call authentication core with appropriate generics, can be taken up in the refactors PR
There was a problem hiding this comment.
This will fixed in the upcoming refactor PR.
| payment_data.authentication = match payment_data.authentication { | ||
| Some((authentication, authentication_data)) => { | ||
| let authentication_update = storage::AuthenticationUpdate::PostAuthorizationUpdate { | ||
| authentication_lifecycle_status: | ||
| storage::enums::AuthenticationLifecycleStatus::Used, | ||
| }; | ||
| let updated_authentication = state | ||
| .store | ||
| .update_authentication_by_merchant_id_authentication_id( | ||
| authentication, | ||
| authentication_update, | ||
| ) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::PaymentNotFound)?; | ||
| Some((updated_authentication, authentication_data)) | ||
| } | ||
| None => None, | ||
| }; |
There was a problem hiding this comment.
this can also be handled in the authentication_core.
There was a problem hiding this comment.
This will fixed in the upcoming refactor PR.
| .attach_printable("Error while parsing authentication_data") | ||
| }) | ||
| .transpose()? | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
this should not be inferred as default.
There was a problem hiding this comment.
This will fixed in the upcoming refactor PR.
There was a problem hiding this comment.
This is fixed in this PR. #4093
likhinbopanna
removed
the
S-waiting-on-review
Type of Change
Description
Added post 3ds authentication, payment authorize endpoint to send authrorization request to the payment connector after completing 3ds authentication separately.
newly added endpoint is
{base_url}/payments/{payment_id}/{merchant_id}/authorize/{connector}.Other changes:
added support for calling pre and post authentication services in payments core.
pre_authn will be called during confirm flow to determine the 3ds version.
post_authn will be called after external authentication is completed to retrieve the authentication data.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy