fix(connectors): fix wallet token deserialization error #4133

AkshayaFoiger · 2024-03-19T12:28:54Z

Type of Change

Description

If deserialization fails for Google pay, Apple Pay and any other wallets token - Hyperswitch should respond with 4xx and proper error message

Test case

Successful payment with Stripe Googlepay

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: {{}}' \
--data-raw '{
    "amount": 1800,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "CustomerX",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
  "type": "PAYMENT_GATEWAY",
  "token": ""
}
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    }
}'

Response

{
    "payment_id": "pay_lWNd2YhWpjq1p9sRGvwk",
    "merchant_id": "merchant_1710919554",
    "status": "succeeded",
    "amount": 1800,
    "net_amount": 1800,
    "amount_capturable": 0,
    "amount_received": 1800,
    "connector": "stripe",
    "client_secret": "pay_lWNd2YhWpjq1p9sRGvwk_secret_Woiaeqo8Yr7ki2p0Abcz",
    "created": "2024-03-20T07:26:10.414Z",
    "currency": "USD",
    "customer_id": "CustomerX",
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "wallet",
    "payment_method_data": {
        "wallet": null,
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "AE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "AE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "Dubai",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        },
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "google_pay",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "CustomerX",
        "created_at": 1710919570,
        "expires": 1710923170,
        "secret": "epk_04ddeab624494488a68423727b63f2da"
    },
    "manual_retry_allowed": false,
    "connector_transaction_id": "pi_3OwJXLD5R7gDAGff1JIpNEtV",
    "frm_message": null,
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pi_3OwJXLD5R7gDAGff1JIpNEtV",
    "payment_link": null,
    "profile_id": "pro_t0UBJ257xhFGAqJMu1xY",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_K91ZLTQVjEJByKfnr181",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-03-20T07:41:10.414Z",
    "fingerprint": null,
    "payment_method_id": null,
    "payment_method_status": null
}

2.Create a failed stripe Googlepay payment - with wrong token struct

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_KeNXoIYIx3E27uTqTCEbrXimCM4LR0FY9PrcPSSksjaLJdz1JW4prgKXSpIAWRiH' \
--data-raw '{
    "amount": 1800,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "CustomerX",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
                    "type": "PAYMENT_GATEWAY",
                    "token": "{\"signature\":\"MEQCIG2DFfixQYapmK983wSKYrYTLuGsBLKYTohGOuLrWoQCAiB6pRV06ZO29tJEElRQYh0coPnvMg6spPtimueQj7R29A\\u003d\\u003d\",\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\":\\\"rO3cpLYvBLkWRHrmI0uWKOQFtekbQS4hiyKKIT5APpahmxUefzJE4URH+8liNh3+tvwthzgnnIEPwDxZfEmgoQktZ7XUe59SBcOS2CqW5jmOU1L6TGPBmGvp1cZ0SiRt8u9ovq8GE1oU6RaINUgSZJTwHwEuf+pTMIIfQmUnyr8l6TH9RCrycodx1bMmA4VfXrbc654/7gTW0/BrURAxozcD2Snu5BQYDdQ5rXe++sN0eMX9pWiW9z3Ovve3Ap6xsct2FkD9FLTF9htj6cH1GgeSn2ozWXsGgyvSt4ZtWsHy1mMSbvWj3LtUc+tyEqun6rVCYg9kozsqFQykp8O0gCDk9oiiHgbtzeUvsPOzEKpl3Fx8uiiEHubBsCviq3OCHE/moNBZWNc7me01yObbpD2sjB3XGgL0tmsVKvpJ5ndau2+pholnYJwCsAAaDQFr4bjbusxy3oRCsCzC\\\",\\\"ephemeralPublicKey\\\":\\\"BP7RtCzgPLGZZRpsSx9X/bsA/rF8Lotv+D25D0oZwVdKa/+UFfoITGQDYRG06MNErXyD0oLnMYvjcxUHPJTDS48\\\\u003d\\\",\\\"tag\\\":\\\"g9AMeqEERJRmEAorxIyNYK5VVDsfLXc/9w1usBiJ0YU\\\\u003d\\\"}\"}"
                }
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    }
}'

Response

{
    "error": {
        "type": "invalid_request",
        "message": "Invalid Googlepay wallet token",
        "code": "IR_20"
    }
}

Zen Applepay and Googlepay

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

ArjunKarthik · 2024-03-21T09:29:14Z

crates/router/src/connector/bankofamerica/transformers.rs

@@ -708,7 +708,9 @@ impl TryFrom<&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>>
                                Self::try_from((item, decrypt_data, apple_pay_data))
                            }
                            types::PaymentMethodToken::Token(_) => {
-                                Err(errors::ConnectorError::InvalidWalletToken)?
+                                Err(errors::ConnectorError::InvalidWalletToken {


This should be payment method not implemented rather than InvalidWalletToken

ArjunKarthik · 2024-03-21T09:43:54Z

crates/router/src/connector/braintree/braintree_graphql_transformers.rs

@@ -1335,7 +1335,9 @@ impl
                    payment_method_id: match item.router_data.get_payment_method_token()? {
                        types::PaymentMethodToken::Token(token) => token.into(),
                        types::PaymentMethodToken::ApplePayDecrypt(_) => {
-                            Err(errors::ConnectorError::InvalidWalletToken)?
+                            Err(errors::ConnectorError::InvalidWalletToken {


Throw not implemented error

ArjunKarthik · 2024-03-21T09:44:01Z

crates/router/src/connector/braintree/braintree_graphql_transformers.rs

@@ -1417,7 +1419,9 @@ fn get_braintree_redirect_form(
        card_token: match payment_method_token {
            types::PaymentMethodToken::Token(token) => token,
            types::PaymentMethodToken::ApplePayDecrypt(_) => {
-                Err(errors::ConnectorError::InvalidWalletToken)?
+                Err(errors::ConnectorError::InvalidWalletToken {


ArjunKarthik · 2024-03-21T09:44:21Z

crates/router/src/connector/checkout/transformers.rs

@@ -308,7 +308,9 @@ impl TryFrom<&CheckoutRouterData<&types::PaymentsAuthorizeRouterData>> for Payme
                        token: match item.router_data.get_payment_method_token()? {
                            types::PaymentMethodToken::Token(token) => token.into(),
                            types::PaymentMethodToken::ApplePayDecrypt(_) => {
-                                Err(errors::ConnectorError::InvalidWalletToken)?
+                                Err(errors::ConnectorError::InvalidWalletToken {


throw not implemented error

ArjunKarthik · 2024-03-21T09:44:33Z

crates/router/src/connector/cybersource/transformers.rs

@@ -140,7 +140,9 @@ impl TryFrom<&types::SetupMandateRouterData> for CybersourceZeroMandateRequest {
                                )
                            }
                            types::PaymentMethodToken::Token(_) => {
-                                Err(errors::ConnectorError::InvalidWalletToken)?
+                                Err(errors::ConnectorError::InvalidWalletToken {


throw not implemented error

ArjunKarthik · 2024-03-21T09:46:10Z

crates/router/src/connector/utils.rs

@@ -921,7 +921,9 @@ impl WalletData for api::WalletData {
    {
        serde_json::from_str::<T>(self.get_wallet_token()?.peek())
            .into_report()
-            .change_context(errors::ConnectorError::InvalidWalletToken)
+            .change_context(errors::ConnectorError::InvalidWalletToken {
+                wallet_name: "".to_string(),


Please add wallet name

ArjunKarthik · 2024-03-21T09:46:13Z

crates/router/src/connector/utils.rs

                let encoded_token = consts::BASE64_ENGINE.encode(token_as_vec);
                Ok(encoded_token)
            }
-            _ => Err(errors::ConnectorError::InvalidWalletToken.into()),
+            _ => Err(errors::ConnectorError::InvalidWalletToken {
+                wallet_name: "".to_string(),


add not implemented

ArjunKarthik · 2024-03-21T09:48:08Z

crates/router/src/connector/utils.rs

            )
            .into_report()
-            .change_context(errors::ConnectorError::InvalidWalletToken)?,
+            .change_context(errors::ConnectorError::InvalidWalletToken {
+                wallet_name: "".to_string(),


please add wallet name

ArjunKarthik · 2024-03-21T09:49:07Z

crates/router/src/core/errors/api_error_response.rs

@@ -79,6 +79,11 @@ pub enum ApiErrorResponse {
        message = "Access forbidden, invalid JWT token was used"
    )]
    InvalidJwtToken,
+    #[error(
+        error_type = ErrorType::ProcessingError, code = "IR_17",


Use new code

ArjunKarthik · 2024-03-21T09:50:01Z

crates/router/src/core/errors/transformers.rs

@@ -95,7 +100,7 @@ impl ErrorSwitch<api_models::errors::types::ApiErrorResponse> for ApiErrorRespon
            Self::FileProviderNotSupported { message } => {
                AER::BadRequest(ApiError::new("IR", 23, message.to_string(), None))
            },
-            Self::UnprocessableEntity {message} => AER::Unprocessable(ApiError::new("IR", 23, message.to_string(), None)),
+            Self::UnprocessableEntity {message} => AER::Unprocessable(ApiError::new("IR", 24, message.to_string(), None)),


this is not required

ArjunKarthik · 2024-03-22T06:44:21Z

crates/router/src/connector/braintree/braintree_graphql_transformers.rs

-            }
+            types::PaymentMethodToken::ApplePayDecrypt(_) => Err(unimplemented_payment_method!(
+                "Apple Pay",
+                "Decrypt",


Use Simplified instead of Decrypt

crates/router/src/core/errors.rs

sai-harsha-vardhan · 2024-03-26T11:45:09Z

crates/router/src/core/errors/utils.rs

@@ -384,7 +384,7 @@ impl<T> ConnectorErrorExt<T> for error_stack::Result<T, errors::ConnectorError>
                | errors::ConnectorError::DateFormattingFailed
                | errors::ConnectorError::InvalidDataFormat { .. }
                | errors::ConnectorError::MismatchedPaymentData
-                | errors::ConnectorError::InvalidWalletToken
+                | errors::ConnectorError::InvalidWalletToken { .. }


Even here ConnectorError::InvalidWalletToken should be mapped to ApiErrorResponse::InvalidWalletToken

* 'main' of github.com:juspay/hyperswitch: refactor(core): removed the processing status for payment_method_status (#4213) docs(README): remove link to outdated early access form build(deps): bump `error-stack` from version `0.3.1` to `0.4.1` (#4188) chore(version): 2024.04.01.0 feat(mandates): allow off-session payments using `payment_method_id` (#4132) ci(CI-pr): determine modified crates more deterministically (#4233) chore(config): add billwerk base URL in deployment configs (#4243) feat(payment_method): API to list countries and currencies supported by a country and payment method type (#4126) chore(version): 2024.03.28.0 refactor(config): allow wildcard origin for development and Docker Compose setups (#4231) fix(core): Amount capturable remain same for `processing` status in capture (#4229) fix(euclid_wasm): checkout wasm metadata issue (#4198) fix(trustpay): [Trustpay] Add error code mapping '800.100.100' (#4224) feat(connector): [billwerk] add connector template code (#4123) fix(connectors): fix wallet token deserialization error (#4133) fix(log): adding span metadata to `tokio` spawned futures (#4118) chore(version): 2024.03.27.0 fix(connector): [CRYPTOPAY] Skip metadata serialization if none (#4205) fix(connector): [Trustpay] fix deserialization error for incoming webhook response for trustpay and add error code mapping '800.100.203' (#4199) fix(core): make eci in AuthenticationData optional (#4187)

refactor(connectors): fix wallet token 5xx error

663ef3f

AkshayaFoiger requested review from a team as code owners March 19, 2024 12:28

AkshayaFoiger self-assigned this Mar 19, 2024

AkshayaFoiger added A-connector-integration Area: Connector integration A-errors Area: error messages, structure & logging labels Mar 19, 2024

AkshayaFoiger changed the title ~~refactor(connectors): fix wallet token 5xx error~~ refactor(connectors): fix wallet token deserialization error Mar 19, 2024

refactor(connectors): update error message

82f4c67

AkshayaFoiger changed the title ~~refactor(connectors): fix wallet token deserialization error~~ fix(connectors): fix wallet token deserialization error Mar 20, 2024

ArjunKarthik reviewed Mar 21, 2024

View reviewed changes

AkshayaFoiger and others added 10 commits March 21, 2024 17:20

refactor(connectors) resolve comments

bcd5351

chore: run formatter

560524c

refactor(connectors): fix mistakes

fb4a644

chore: run formatter

556e6ac

refactor(connectors): error building

4f0560f

chore: run formatter

78e95f3

refactor(connectors): fix errors

94e3821

chore: run formatter

7b7f8de

refactor(cybersource): update error

1a330d7

chore: run formatter

3e8b2f4

ArjunKarthik reviewed Mar 22, 2024

View reviewed changes

AkshayaFoiger and others added 2 commits March 26, 2024 11:35

refactor(connectors): rename decrypt error msg

641c33e

chore: run formatter

36ba72c

ArjunKarthik previously approved these changes Mar 26, 2024

View reviewed changes

AkshayaFoiger commented Mar 26, 2024

View reviewed changes

crates/router/src/core/errors.rs Outdated Show resolved Hide resolved

Update crates/router/src/core/errors.rs

9be4308

AkshayaFoiger dismissed ArjunKarthik’s stale review via 9be4308 March 26, 2024 10:30

ArjunKarthik previously approved these changes Mar 26, 2024

View reviewed changes

sai-harsha-vardhan reviewed Mar 26, 2024

View reviewed changes

resolve comment

bee67e5

AkshayaFoiger dismissed ArjunKarthik’s stale review via bee67e5 March 26, 2024 11:54

AkshayaFoiger requested a review from ArjunKarthik March 26, 2024 11:57

sai-harsha-vardhan approved these changes Mar 26, 2024

View reviewed changes

ArjunKarthik approved these changes Mar 26, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Mar 27, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Mar 27, 2024

Merged via the queue into main with commit 929848f Mar 27, 2024
13 of 15 checks passed

Gnanasundari24 deleted the fix-wallet-5xx-error branch March 27, 2024 06:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(connectors): fix wallet token deserialization error #4133

fix(connectors): fix wallet token deserialization error #4133

AkshayaFoiger commented Mar 19, 2024 •

edited

Loading

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 21, 2024

ArjunKarthik Mar 22, 2024

sai-harsha-vardhan Mar 26, 2024

fix(connectors): fix wallet token deserialization error #4133

fix(connectors): fix wallet token deserialization error #4133

Conversation

AkshayaFoiger commented Mar 19, 2024 • edited Loading

Type of Change

Description

Test case

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshayaFoiger commented Mar 19, 2024 •

edited

Loading