Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): Add payment cancel events #4166

Merged
merged 63 commits into from
Apr 15, 2024
Merged

feat(events): Add payment cancel events #4166

merged 63 commits into from
Apr 15, 2024

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Mar 21, 2024 •
edited by Gnanasundari24
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • pass along request_state to payment_core
  • update updatetrackers trait to accept request state
  • update the paymentcancel implementation of updatetracker to generate an event

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Generating domain events that can be used to track the high level overview of any process

How did you test it?

  • create a payment & then cancel it
{"topic" = "hyperswitch-api-events"}

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

lsampras and others added 30 commits February 27, 2024 16:24
@lsampras
refactor(events): remove intermediary raw event and instead rely on t…
71912ff 
…raits for behaviour
@lsampras
chore(makefile): update the default behaviour or make fmt to mutate t…
bba344e 
…he files
@lsampras
Merge remote-tracking branch 'origin/main' into create-payment-lifecy…
1c8c721 
…cle-events
@lsampras
feat(events): add support for generating audit events
679f233
@lsampras
refactor(events): add event setup in payment data
a9a7256
@lsampras
refactor(clippy): fix large futures
3bd533c
@lsampras
Merge remote-tracking branch 'origin/main' into create-payment-lifecy…
f2f9735 
…cle-events
@lsampras
fix(events): remove payment data changes field
8b1eea9
@hyperswitch-bot
chore: run formatter
6121889
@lsampras
feat(events): remove event generation logic
fdd3ca4
@lsampras
Merge branch 'main' into create-payment-lifecycle-events
60ccc32
@hyperswitch-bot
chore: run formatter
8341a4a
@lsampras
chore(clippy): fix big futures
815aa59
@lsampras
chore(config): update config placeholders
06f72d3
@lsampras
feat(events): add events framework
f4dedc9
@lsampras
chore(events): add docstrings for events interface
af52920
@lsampras
feat(events): imple event sink for kafka
33cb42d
@lsampras
feat(events): use events framework for event handler
6855195
@lsampras
Merge remote-tracking branch 'origin/main' into add_events_crate
44c5bf5
@hyperswitch-bot
chore: run formatter
e21d292
@lsampras
Merge remote-tracking branch 'origin/main' into add_events_crate
b32f1ac
@lsampras
Merge branch 'main' into add_events_crate
8302161
@lsampras
feat(events): support extraction of root level data from event
08639ea
@hyperswitch-bot
chore: run formatter
4f5da96
@lsampras
refactor(app): remove generics for appstateinfo from server_wrap
2e1e689
@lsampras
Merge branch 'main' into add_events_crate
f674547
@lsampras
feat(events): add a request context generated from server_wrap
2025dce
@lsampras
Merge branch 'add_events_crate' of github.com:juspay/hyperswitch into…
1d8ab48 
… add_events_crate
@lsampras
Merge branch 'main' into add_events_crate
6bce3aa
@lsampras
chore(lints): fix clippy unused lint
1a10bbd
@lsampras lsampras force-pushed the add_payment_cancel_events branch from 724e2e7 to b0a35b5 Compare April 12, 2024 08:36
@lsampras lsampras linked an issue Apr 12, 2024 that may be closed by this pull request
feat(events): create a framework for emitting events & capture audit/lifecycle events from application #4088
Closed
ThisIsMani
ThisIsMani approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ThisIsMani ThisIsMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard specific changes looks fine.

Chethan-rao
Chethan-rao approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Chethan-rao Chethan-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routing specific changes LGTM

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit dea21c6 Apr 15, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add_payment_cancel_events branch April 15, 2024 10:49
@lsampras lsampras mentioned this pull request May 2, 2024
Open
13 tasks
@lsampras lsampras mentioned this pull request May 17, 2024
Closed
@kaustubh1106 kaustubh1106 mentioned this pull request May 28, 2024
Open
This was referenced Sep 24, 2024
Closed
Closed
Open
Open
Closed
Closed
Open
Closed
This was referenced Oct 28, 2024
Merged
Merged
Merged
@tsdk02 tsdk02 mentioned this pull request Oct 30, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivanshMathurJuspay ShivanshMathurJuspay ShivanshMathurJuspay approved these changes

@ThisIsMani ThisIsMani ThisIsMani approved these changes

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@lsampras lsampras

Labels
A-Analytics A-framework Area: Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(events): create a framework for emitting events & capture audit/lifecycle events from application
6 participants
@lsampras @Narayanbhat166 @Chethan-rao @ThisIsMani @ShivanshMathurJuspay @Gnanasundari24