feat(customer): Customer kv impl #4267
Conversation
| pub async fn update( | ||
| self, | ||
| conn: &PgPooledConn, | ||
| customer: CustomerUpdateInternal, | ||
| ) -> StorageResult<Self> { | ||
| match generics::generic_update_by_id::<<Self as HasTable>::Table, _, _, _>( | ||
| conn, | ||
| (self.customer_id.clone(), self.merchant_id.clone()), | ||
| customer, | ||
| ) | ||
| .await | ||
| { | ||
| Err(error) => match error.current_context() { | ||
| errors::DatabaseError::NoFieldsToUpdate => { | ||
| generics::generic_find_by_id::<<Self as HasTable>::Table, _, _>( | ||
| conn, | ||
| (self.customer_id, self.merchant_id), | ||
| ) | ||
| .await | ||
| } | ||
| _ => Err(error), | ||
| }, | ||
| result => result, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This look like a redundant function
crates/router/src/core/customers.rs
Outdated
| @@ -186,10 +187,11 @@ pub async fn delete_customer( | |||
| ) -> errors::CustomerResponse<customers::CustomerDeleteResponse> { | |||
| let db = &state.store; | |||
|
|
|||
| db.find_customer_by_customer_id_merchant_id( | |||
| let _customer = db.find_customer_by_customer_id_merchant_id( | |||
There was a problem hiding this comment.
You can remove the underscore here
| let merchant_account = db.find_merchant_account_by_merchant_id(merchant_id, key_store) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::MerchantAccountNotFound)?; |
There was a problem hiding this comment.
You can pass the merchant account from the previous function. No need of another DB call here
| @@ -1157,11 +1157,13 @@ pub async fn get_customer_from_details<F: Clone>( | |||
| match customer_id { | |||
| None => Ok(None), | |||
| Some(c_id) => { | |||
| let merchant_account = db.find_merchant_account_by_merchant_id(merchant_id , merchant_key_store).await?; | |||
There was a problem hiding this comment.
You can pass it from prev function
| @@ -1309,13 +1311,15 @@ pub async fn create_customer_if_not_exist<'a, F: Clone, R, Ctx>( | |||
| .customer_id | |||
| .or(payment_data.payment_intent.customer_id.clone()); | |||
|
|
|||
| let merchant_account = db.find_merchant_account_by_merchant_id(merchant_id, key_store).await?; | |||
crates/router/src/db/customers.rs
Outdated
| let updated_object = match storage_scheme { | ||
| MerchantStorageScheme::PostgresOnly => database_call().await, | ||
| MerchantStorageScheme::RedisKv => { | ||
| let key = format!("mid_{}_cust_{}", merchant_id, customer_id); |
There was a problem hiding this comment.
Should the key be merchant_id_customer_id? I dont think this serves the purpose of sharding all the data with single key. Should we think of something else
cc: @jarnura
There was a problem hiding this comment.
i was thinking mandate data can also come under mid_cust_id
There was a problem hiding this comment.
But for address it's mid_pid because only payment related address is going to KV
There was a problem hiding this comment.
how does that work, would address be changed or created only in payments flow
There was a problem hiding this comment.
Yes the addresses which are going through KV flow are only inserted during payments
akshay-97
force-pushed
the
customer_kv_impl
branch
from
bd0ba8d to
370f81d
Compare
Type of Change
Description
Add kv support for customer table, so that writes and updates dont go to master db
Additional Changes
Motivation and Context
Since payment flows can write to customer table, this entity needs to be supported in KV
How did you test it?
enable kv config for test merchant
create customer
curl --location 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key:***' \ --data-raw '{ "email": "guest@example.com", "name": "John Doe", "phone": "999999999", "phone_country_code": "+65", "description": "First customer", "metadata": { "udf1": "value1", "new_customer": "true", } }'create payment_method with same customer
curl --location 'http://localhost:8080/payment_methods' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key:***' \ --data '{ "payment_method": "card", "payment_method_type": "credit", "payment_method_issuer": "Visa", "card": { "card_number": "4242424242424242", "card_exp_month": "10", "card_exp_year": "25", "card_holder_name": "John Doe" }, "customer_id": <cust_id>, "metadata": { "city": "NY", "unit": "245" } }'check drainer for errors
check in db after drainer has run for existence of payment method and customer info
Checklist
cargo +nightly fmt --allcargo clippy