Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_link): Decouple shimmer css from main payment_link css for better performance #4286

Merged
merged 2 commits into from
Apr 4, 2024
Merged

refactor(payment_link): Decouple shimmer css from main payment_link css for better performance #4286

merged 2 commits into from
Apr 4, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Apr 3, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Decouple shimmer css from main payment link css for better performance

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No Test cases involved its just a performance improvement.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Apr 3, 2024
@sahkal sahkal added this to the April 2024 milestone Apr 3, 2024
@sahkal sahkal self-assigned this Apr 3, 2024
@sahkal sahkal requested a review from a team as a code owner April 3, 2024 10:40
@sahkal sahkal changed the title refactor(payment_link): decoupled shimmer css from main css refactor(payment_link): Decouple shimmer css from main css Apr 3, 2024
@sahkal sahkal changed the title refactor(payment_link): Decouple shimmer css from main css refactor(payment_link): Decouple shimmer css from main payment_link css for better performance Apr 3, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 9453e8f Apr 4, 2024
9 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the decouple-shimmer-css-payment-link branch April 4, 2024 07:25
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@sahkal sahkal

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
April 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sahkal @SanchithHegde @Narayanbhat166 @Gnanasundari24