Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): integrate netcetera connector with pre authentication flow #4293

Merged
merged 16 commits into from
Apr 16, 2024
Merged

feat(connector): integrate netcetera connector with pre authentication flow #4293

merged 16 commits into from
Apr 16, 2024

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Apr 3, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Generated Connector template code for Netcetera Authentication connector and implemented PreAuthentication Flow.

netcetera api reference: https://3dss.netcetera.com/3dsserver-saas/doc/2.9.0.0/3ds-versioning

Other changes:
Introduced CertificateAuth type to ConnectorAuthType enum.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual
Screenshot 2024-04-04 at 3 07 45 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 3, 2024
@hrithikesh026 hrithikesh026 added this to the April 2024 milestone Apr 3, 2024
@hrithikesh026 hrithikesh026 self-assigned this Apr 3, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners April 3, 2024 20:07
SamraatBansal
SamraatBansal requested changes Apr 10, 2024
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/admin.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
SamraatBansal
SamraatBansal previously approved these changes Apr 12, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit d4dbaad Apr 16, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the integrate-netcetera branch April 16, 2024 10:38
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
April 2024 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@hrithikesh026 @ArjunKarthik @SamraatBansal @sai-harsha-vardhan @SanchithHegde @likhinbopanna