Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(user): Deprecate Signin, Verify email and Invite v1 APIs #4465

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented Apr 25, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR will remove the following endpoints and corresponding APIs
/user/signin
/user/verify_email
/user/invite

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #4464

How did you test it?

curl --location 'http://localhost:8080/user/signin' \
--header 'Content-Type: application/json' \
--data '{
    "email": "user email",
    "password": "password"
}'
curl --location 'http://localhost:8080/user/verify_email' \
--header 'Content-Type: application/json' \
--data '{
    "token": "email token"
}'
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data '{
    "email": "email",
    "name": "name",
    "role_id": "merchant_view_only"
}'

When these curls are hit, BE will respond with 404 Not Found with the following body

{
    "error": {
        "type": "invalid_request",
        "message": "Unrecognized request URL",
        "code": "IR_02"
    }
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ThisIsMani ThisIsMani self-assigned this Apr 25, 2024
@ThisIsMani ThisIsMani requested review from a team as code owners April 25, 2024 09:18
@ThisIsMani ThisIsMani changed the title refactor(user): Deprecate Signin, Verify email and Invite v1 apis refactor(user): Deprecate Signin, Verify email and Invite v1 APIs Apr 25, 2024
@ThisIsMani ThisIsMani added C-refactor Category: Refactor A-users Area: Users labels Apr 30, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit b0133f3 Apr 30, 2024
16 of 18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the deprecate-v1-user-apis branch April 30, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: deprecate V1 signin, verify email and invite APIs
5 participants