Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Payone] add connector template code #4469

Merged
merged 9 commits into from
May 9, 2024

Conversation

KiranKBR
Copy link
Contributor

@KiranKBR KiranKBR commented Apr 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template code for Payone Payout

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/4902

How did you test it?

This is template code so, no api testing required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@KiranKBR KiranKBR requested review from a team as code owners April 26, 2024 08:08
@KiranKBR KiranKBR added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Apr 27, 2024
@srujanchikke srujanchikke added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 8, 2024
@KiranKBR KiranKBR force-pushed the payone-template-code branch from 2abc532 to 59e91f4 Compare May 8, 2024 10:04
@KiranKBR KiranKBR force-pushed the payone-template-code branch from 00c9e07 to 9e5431a Compare May 8, 2024 10:26
@KiranKBR KiranKBR force-pushed the payone-template-code branch from 6d5af48 to 8091042 Compare May 8, 2024 13:54
@@ -142,6 +142,7 @@ impl<const T: u8>
}

default_imp_for_complete_authorize!(
connector::Payone,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added in alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -2574,6 +2602,7 @@ impl<const T: u8>
{
}
default_imp_for_connector_authentication!(
connector::Payone,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the connector enum in alphabetical order in all other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@KiranKBR KiranKBR force-pushed the payone-template-code branch from 359272a to fef9429 Compare May 9, 2024 03:27
@KiranKBR KiranKBR force-pushed the payone-template-code branch from c07bebf to 00160d7 Compare May 9, 2024 06:05
@SamraatBansal SamraatBansal added the M-configuration-changes Metadata: This PR involves configuration changes label May 9, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit f386f42 May 9, 2024
24 of 27 checks passed
@Gnanasundari24 Gnanasundari24 deleted the payone-template-code branch May 9, 2024 10:17
pixincreate added a commit that referenced this pull request May 10, 2024
…efactor

* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2024.05.10.0
  fix(router): [NETCETERA] skip sending browser_information in authentication request for app device_channel (#4613)
  fix(users): Fix bugs caused by the new token only flows (#4607)
  ci(cypress): Fix card expiry for savecard flows (#4585)
  refactor(billing): store `payment_method_data_billing` for recurring payments (#4513)
  feat(users): new routes to accept invite and list merchants (#4591)
  fix(connector): [BAMBORA] Audit Fixes for Bambora (#4604)
  fix(connector): [iatapay]handle empty error response in case of 401 (#4291)
  feat(connector): [Payone] add connector template code (#4469)
  feat(users): Create API to Verify TOTP (#4597)
  chore(version): 2024.05.09.0
  chore(postman): update Postman collection files
  fix(core): drop three_dsserver_trans_id from authentication table (#4587)
  refactor(db): Add TenantId field to the KafkaStore struct (#4512)
  feat(users): Create `user_key_store` table and `begin_totp` API (#4577)
  Fix(connector): [BOA/CYBS] make rsync status optional (#4570)
  fix(users): Correct the condition for `verify_email` flow in decision manger (#4580)
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants