feat(core): add support for connectors having separate version call for pre authentication #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nticaition connector
…or pre authentication
hrithikesh026
requested review from
Narayanbhat166,
sai-harsha-vardhan and
SamraatBansal
hrithikesh026
added
A-core
config/config.example.toml
Outdated
| sdk_eligible_payment_methods = "card" | ||
|
|
||
| [separate_three_ds_version_call_enabled_connectors] |
There was a problem hiding this comment.
This need not be an env, as it can't be changed in runtime. We can have this check in impl Connector
sai-harsha-vardhan
approved these changes
May 19, 2024
Narayanbhat166
approved these changes
May 21, 2024
sai-harsha-vardhan
approved these changes
May 21, 2024
SanchithHegde
approved these changes
May 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
SanchithHegde
deleted the
add-support-for-3ds-connectors-with-separate-version-call
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added support for connectors having separate version call for pre authentication.
Few authentication connectors like Gpayments require two different api calls to complete pre authentication call(version call and 3ds method call). Hence added a new external authentication flow as part of pre authentication.
other changes in core:
Before making pre auth connector call, check if connector supports separate verison call.
If yes, complete version call and then proceed with pre auth call.
Additional Changes
Motivation and Context
How did you test it?
Cannot be tested until Gpayments external 3ds authenticator integration is completed.
Checklist
cargo +nightly fmt --allcargo clippy