feat(webhook): add frm webhook support #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujanchikke
added
A-core
srujanchikke
changed the title
srujanchikke
changed the title
srujanchikke
changed the title
…_webhooks Signed-off-by: chikke srujan <121822803+srujanchikke@users.noreply.github.com>
crates/router/src/core/webhooks.rs
Outdated
| payments::PaymentApprove, | ||
| api::PaymentsCaptureRequest { | ||
| payment_id: payment_attempt.payment_id, | ||
| amount_to_capture: Some(payment_attempt.amount), |
There was a problem hiding this comment.
Please send payment_attempt.amount_to_capture here
crates/router/src/core/webhooks.rs
Outdated
| HeaderPayload::default(), | ||
| )) | ||
| .await?; | ||
| match payments_response { |
There was a problem hiding this comment.
Can remove this redundant logic and get the payments_response using the event type
crates/router/src/core/webhooks.rs
Outdated
| .change_context(errors::ApiErrorResponse::WebhookProcessingFailure) | ||
| .attach_printable("payment id not received from payments core")?; | ||
| let status = payments_response.status; | ||
| let _event_type: Option<enums::EventType> = |
There was a problem hiding this comment.
Please trigger an outgoing webhook here
crates/router/src/core/webhooks.rs
Outdated
| key_store: domain::MerchantKeyStore, | ||
| source_verified: bool, | ||
| event_type: webhooks::IncomingWebhookEvent, | ||
| _request_details: &api::IncomingWebhookRequestDetails<'_>, |
There was a problem hiding this comment.
Please remove unused fields here
Sakilmostak
requested changes
May 21, 2024
crates/router/src/core/webhooks.rs
Outdated
| business_profile, | ||
| )) | ||
| .await | ||
| .attach_printable("Incoming webhook flow for external authentication failed")?, |
There was a problem hiding this comment.
Suggested change
| .attach_printable("Incoming webhook flow for external authentication failed")?, | |
| .attach_printable("Incoming webhook flow for fraud check failed")?, |
kashif-m
approved these changes
May 22, 2024
Sakilmostak
approved these changes
May 22, 2024
sai-harsha-vardhan
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces FRM webhooks . Frm webhooks are consumed when payments are held due to manual review pending from FRM processors. When merchant/ Frm provides decision , webhook is triggered . Based on decision we take action whether to approve or decline the payment.
Additional Changes
Motivation and Context
Upon merchant decision on manual review, FRM send us webhooks. Based on FRM webhooks decision we should approve/decline the transaction.
How did you test it?
Test cases
1 . Test signifyd webhooks.(process both incoming and outgoing webhooks)
2. Test any payment processor webhook.
Checklist
cargo +nightly fmt --allcargo clippy