refactor(graph): refactor the Knowledge Graph to include configs check, while eligibility analysis #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…ac-eligibity-analysis
…hyperswitch into refac-eligibity-analysis
vspecky
requested changes
May 21, 2024
crates/kgraph_utils/src/mca.rs
Outdated
| .filter(|p| enabled_pmt.clone().into_iter().any(|d| &d != p)) | ||
| .collect::<Vec<_>>(); | ||
| global_vector | ||
| .clone() |
| cgraph::Relation::Positive, | ||
| cgraph::Strength::Normal, | ||
| )); | ||
| if let Some(country) = config.country.clone() { |
There was a problem hiding this comment.
I feel like the .clone() can be avoided.
| )) | ||
| } | ||
|
|
||
| if let Some(currency) = config.currency.clone() { |
There was a problem hiding this comment.
The .clone() here probably can be avoided too.
crates/kgraph_utils/src/mca.rs
Outdated
| }) | ||
| .transpose()?; | ||
|
|
||
| if let Some(_country_currency) = curr { |
There was a problem hiding this comment.
I'm kinda surprised clippy didn't suggest this.
Suggested change
| if let Some(_country_currency) = curr { | |
| if curr.is_some() { |
crates/kgraph_utils/src/mca.rs
Outdated
Comment on lines
638
to
649
| // PaymentMethodsEnabled { | ||
| // payment_method: api_enums::PaymentMethod::Wallet, | ||
| // payment_method_types: Some(vec![RequestPaymentMethodTypes { | ||
| // payment_method_type: api_enums::PaymentMethodType::GooglePay, | ||
| // payment_experience: None, | ||
| // card_networks: None, | ||
| // accepted_currencies: Some(AcceptedCurrencies::EnableOnly(vec![ | ||
| // api_enums::Currency::USD, | ||
| // api_enums::Currency::INR, | ||
| // ])), | ||
| // accepted_countries: None, | ||
| // minimum_amount: Some(10), |
Comment on lines
132
to
147
| impl IntoDirValue for api_enums::PaymentMethodType { | ||
| fn into_dir_value(self) -> Result<dir::DirValue, KgraphError> { | ||
| match self { | ||
| Self::Credit => Ok(dirval!(CardType = Credit)), | ||
| Self::Debit => Ok(dirval!(CardType = Debit)), | ||
| Self::Giropay => Ok(dirval!(BankRedirectType = Giropay)), | ||
| Self::Ideal => Ok(dirval!(BankRedirectType = Ideal)), | ||
| Self::Sofort => Ok(dirval!(BankRedirectType = Sofort)), | ||
| Self::Eps => Ok(dirval!(BankRedirectType = Eps)), | ||
| Self::Klarna => Ok(dirval!(PayLaterType = Klarna)), | ||
| Self::Affirm => Ok(dirval!(PayLaterType = Affirm)), | ||
| Self::AfterpayClearpay => Ok(dirval!(PayLaterType = AfterpayClearpay)), | ||
| Self::GooglePay => Ok(dirval!(WalletType = GooglePay)), | ||
| Self::ApplePay => Ok(dirval!(WalletType = ApplePay)), | ||
| Self::Paypal => Ok(dirval!(WalletType = Paypal)), | ||
| Self::CryptoCurrency => Ok(dirval!(CryptoType = CryptoCurrency)), |
There was a problem hiding this comment.
Don't have this as an IntoDirValue impl. Instead have it as a private function in kgraph_utils::mca, since we don't want to encourage its usage.
crates/kgraph_utils/src/utils.rs
Outdated
There was a problem hiding this comment.
I would argue naming the file types.rs is more appropriate. But utils.rs works too.
There was a problem hiding this comment.
have empty lines between function definitions
vspecky
requested changes
May 21, 2024
vspecky
approved these changes
May 21, 2024
prajjwalkumar17
approved these changes
May 21, 2024
| @@ -28,7 +28,7 @@ impl From<DomainId> for DomainIdOrIdentifier<'_> { | |||
| Self::DomainId(value) | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
There was a problem hiding this comment.
If possible we can revert the added Derive implemetations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactor the Knowledge Graph to include configs(pm_filters) check, while eligibility analysis
Additional Changes
Motivation and Context
How did you test it?
Wrote unit test
To test it,
You can create MCA for 2 connectors
Do a payment using BOA and with some currency that it doesn't support , for eg:INR
Checklist
cargo +nightly fmt --allcargo clippy