-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): Add audit events payment confirm #4763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhitator216
changed the title
Add audit events payement confirm
feat(events): Add audit events payement confirm
May 24, 2024
Abhitator216
changed the title
feat(events): Add audit events payement confirm
feat(events): Add audit events payment confirm
May 24, 2024
lsampras
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits
Co-authored-by: Sampras Lopes <Sampras.lopes@juspay.in>
lsampras
previously approved these changes
Jun 3, 2024
ShivanshMathurJuspay
previously approved these changes
Jun 3, 2024
Abhitator216
dismissed stale reviews from ShivanshMathurJuspay and lsampras
via
June 4, 2024 07:21
d975b29
lsampras
previously approved these changes
Jun 4, 2024
config/development.toml
Outdated
@@ -566,7 +566,7 @@ soft_kill = false | |||
enabled = true | |||
|
|||
[events] | |||
source = "logs" | |||
source = "kafka" | |||
|
|||
[events.kafka] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this change, as this is for local development
ShivanshMathurJuspay
approved these changes
Jun 7, 2024
lsampras
approved these changes
Jun 7, 2024
ivor11
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
updatetrackers
trait to accept request stateAdditional Changes
Motivation and Context
How did you test it?
Test Case Description
client_src
,client_ver
andfrm_message
.Checklist
cargo +nightly fmt --all
cargo clippy