-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add an api to migrate the apple pay certificates from connector metadata to connector_wallets_details
column in merchant connector account
#4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnector metadata to connector_wallets_details column in merchant connector account
ShankarSinghC
added
A-core
Area: Core flows
A-payment-methods
Area: Payment Methods
labels
May 28, 2024
…perswitch into apple_pay/migrate-cert
jagan-jaya
requested changes
May 30, 2024
…le_pay/migrate-cert
Co-authored-by: Sanchith Hegde <22217505+SanchithHegde@users.noreply.github.com>
SanchithHegde
approved these changes
Jun 5, 2024
ivor11
approved these changes
Jun 6, 2024
jagan-jaya
approved these changes
Jun 6, 2024
Chethan-rao
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juspay/hyperswitch-routing related changes LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently apple pay related details are being stored in the connector metadata, as in future we are going to add apple pay decrypted flow support for ios app we will be collecting the apple pay payment processing certificates as well. As this ppc and ppc key needs to be securely stored, we need to move the existing certificates to a new column which stores the encrypted certificates.
This pr adds a api end point (
/apple_pay_certificates_migration
) to migrate the apple pay details form the merchant connector accountmetadata
to the newly added column connector (connector_wallets_details
). This api takes list ofmerchant_ids
as input and then lists all the configured merchant connector accounts for that merchant id. After which it checks for the apple pay details in the metadata in the merchant connector account, if present it is encrypted by merchant's DEK (Data Encryption Key) and will be stored in the newly added column (connector_wallets_details
) in the merchant connector account. Response contains the list of merchant_ids for migration succeeded (migration_successful
) and failed (migraiton_failed
).Additional Changes
Motivation and Context
How did you test it?
-> Apple pay certificate migration api
-> Create MCA with apple pay
simplified
and manualflow
metadata for apple pay
simplified
metadata for apple pay
manual
flow-> Confirm an apple pay payment with above flows
-> Create a apple pay payment with the below metadata
-> Confirm apple pay payment
Checklist
cargo +nightly fmt --all
cargo clippy