Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement StrongEq for Vec<u8> #4795

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: implement StrongEq for Vec<u8> #4795

merged 1 commit into from
May 29, 2024

Conversation

dracarys18
Copy link
Member

Type of Change

  • Enhancement

Description

Implement StrongEq for Vec<u8>

Motivation and Context

Implement StrongEq for deriving Eq for StrongSecret<Vec<u8>>.

How did you test it?

NA. Testing is not needed, compiler guided.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 28, 2024
@dracarys18 dracarys18 added this to the May 2024 Release milestone May 28, 2024
@dracarys18 dracarys18 self-assigned this May 28, 2024
@dracarys18 dracarys18 requested a review from a team as a code owner May 28, 2024 14:04
@dracarys18 dracarys18 linked an issue May 28, 2024 that may be closed by this pull request
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit b812e59 May 29, 2024
12 of 13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add_strong_eq_vec branch May 29, 2024 09:37
ghost pushed a commit that referenced this pull request May 29, 2024
…actor

* 'main' of github.com:juspay/hyperswitch: (39 commits)
  Fix(Cypress): Fixing 3DS payment failure in headless mode (#4807)
  feat(users): Add redis in Begin and Verify TOTP and create a new API that updates TOTP (#4765)
  refactor(connector): [Klarna] Refactor Authorize call and configs for prod (#4750)
  fix: implement StrongEq for Vec<u8> (#4795)
  refactor(core): move router data response and request models to hyperswitch domain models crate (#4789)
  chore(version): 2024.05.29.0
  refactor: retrieve extended card info config during business profile get call (#4784)
  refactor(payment_methods): add support for passing ttl to locker entries (#4690)
  feat(connector): [CRYPTOPAY] Pass network details in payment request (#4779)
  fix: include client columns in payment attempts response struct (#4761)
  fix(docker-compose): fix docker compose syntax (#4782)
  feat(connector): [Iatapay] add upi qr support (#4728)
  docs(analytics): Add documentation for setting up data services and enabling data features in control center (#4741)
  chore(version): 2024.05.28.0
  feat(connector): [AUTHORIZEDOTNET] Implement non-zero mandates (#4758)
  feat(core): [Paypal] Add session_token flow for Paypal sdk (#4697)
  chore(version): 2024.05.27.0
  chore: add missing migrations for recently added currencies (#4760)
  Refactor(core): Inclusion of constraint graph for merchant Payment Method list (#4626)
  chore(version): 2024.05.24.1
  ...
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] implement StrongEq for StrongSecre<Vec<u8>>
4 participants