refactor(conditional_configs): refactor conditional_configs to use Moka Cache instead of Static Cache #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprabhat19
added
S-waiting-on-review
…he-decision-manager
…perswitch into cache-decision-manager
Comment on lines
386
to
390
| let value_to_cache = || async { | ||
| VirInterpreterBackendCacheWrapper::try_from(record) | ||
| .change_context(errors::StorageError::ValueNotFound("Program".to_string())) | ||
| .attach_printable("Error initializing DSL interpreter backend") | ||
| }; |
There was a problem hiding this comment.
You can move the DB call to fetch the config (and thus parsing the record) within the closure, to avoid unnecessary DB calls.
Comment on lines
48
to
52
| let find_key_from_db = || async { | ||
| backend::VirInterpreterBackend::with_program(rec.program) | ||
| .change_context(ConfigError::DslBackendInitError) | ||
| .attach_printable("Error initializing DSL interpreter backend")?; | ||
| CONF_CACHE | ||
| .save(key, interpreter, timestamp) | ||
| .change_context(ConfigError::DslCachePoisoned) | ||
| .attach_printable("Error saving DSL to cache")?; | ||
| Ok(()) | ||
| .change_context(errors::StorageError::ValueNotFound("Program".to_string())) | ||
| .attach_printable("Error initializing DSL interpreter backend") | ||
| }; |
There was a problem hiding this comment.
Similar change can be done here.
| @@ -517,7 +517,7 @@ async fn publish_and_redact_merchant_account_cache( | |||
| let kgraph_key = merchant_account.default_profile.as_ref().map(|profile_id| { | |||
There was a problem hiding this comment.
Suggested change
| let kgraph_key = merchant_account.default_profile.as_ref().map(|profile_id| { | |
| let cgraph_key = merchant_account.default_profile.as_ref().map(|profile_id| { |
| @@ -527,7 +527,7 @@ async fn publish_and_redact_merchant_account_cache( | |||
|
|
|||
| #[cfg(not(feature = "business_profile_routing"))] | |||
| let kgraph_key = Some(CacheKind::CGraph( | |||
There was a problem hiding this comment.
Suggested change
| let kgraph_key = Some(CacheKind::CGraph( | |
| let cgraph_key = Some(CacheKind::CGraph( |
2 tasks
SanchithHegde
previously approved these changes
Jun 5, 2024
vspecky
requested changes
Jun 5, 2024
hrithikesh026
previously approved these changes
Jun 5, 2024
Aprabhat19
dismissed stale reviews from hrithikesh026 and SanchithHegde
via
1604e92
vspecky
requested changes
Jun 6, 2024
…he-decision-manager
…perswitch into cache-decision-manager
SanchithHegde
approved these changes
Jun 7, 2024
14 tasks
hrithikesh026
approved these changes
Jun 11, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
refactor conditional_configs to use Moka Cache instead of Static Cache
Additional Changes
Motivation and Context
How did you test it?
Cannot be tested
Checklist
cargo +nightly fmt --allcargo clippy