-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(process_tracker): use const
instead of String
for business_status
#4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-process-tracker
Area: Process tracker
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
Jun 3, 2024
pixincreate
force-pushed
the
process-tracker-db-refactor
branch
from
June 8, 2024 11:36
80bb945
to
726fc5f
Compare
pixincreate
force-pushed
the
business_status_pt
branch
2 times, most recently
from
June 8, 2024 17:11
ddde33c
to
9bc7628
Compare
pixincreate
force-pushed
the
business_status_pt
branch
2 times, most recently
from
June 8, 2024 17:39
61431c6
to
9885e0c
Compare
pixincreate
force-pushed
the
process-tracker-db-refactor
branch
2 times, most recently
from
June 9, 2024 08:04
e81be8b
to
314b727
Compare
pixincreate
added
S-blocked
Status: Blocked on something else or other implementation work
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jun 11, 2024
pixincreate
force-pushed
the
process-tracker-db-refactor
branch
2 times, most recently
from
June 12, 2024 10:05
102184f
to
33c8e22
Compare
14 tasks
pixincreate
removed
the
S-blocked
Status: Blocked on something else or other implementation work
label
Jun 13, 2024
pixincreate
force-pushed
the
business_status_pt
branch
from
June 13, 2024 14:52
9885e0c
to
0656d4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me!
Co-authored-by: SanchithHegde <22217505+SanchithHegde@users.noreply.github.com>
SanchithHegde
approved these changes
Jun 14, 2024
pixincreate
force-pushed
the
business_status_pt
branch
from
June 14, 2024 10:05
058fa0a
to
de86ca4
Compare
lsampras
approved these changes
Jun 14, 2024
pixincreate
added a commit
that referenced
this pull request
Jun 20, 2024
…ress-skip * 'main' of github.com:juspay/hyperswitch: (27 commits) feat(cypress): add 2 more payout connectors and bank transfer support for payout (#4993) chore(version): 2024.06.20.0 Refactor(core): reverts the payment method list filtering using constraint graph (#5044) feat(router): add payment method type duplication check for `google_pay` (#5023) refactor(storage): remove `id` from payment intent, attempt and remove datamodel ext from payment intent (#4923) fix(events): Correct parsing of API events with user event_type for Clickhouse (#5022) fix(connector): add local bank redirect type in compatibility layer, default the country to AT for Local Bank Redirect and add creds_identifier in access token (#5038) refactor(connector): add amount conversion framework for noon (#4843) fix(logging): fix stack overflow on recording restricted keys (#4423) feat(core): Add logger for sessions call failure (#5036) chore(version): 2024.06.19.0 fix(opensearch): handle index not present errors in search api (#4965) feat(multitenancy): add tenant_id as a field for data pipeline and support individual database for clickhouse (#4867) refactor: add basic counter metrics for IMC (#5006) fix(payment_methods): populate card fields while saving card again during metadata change condition (#5019) feat(router): Override the `setup_future_usage` to `on_session` based on the merchant config (#5016) chore(docker-compose): pass correct configuration values for running SDK demo app (#5012) refactor: Move trait ConnectorIntegration to crate hyperswitch_interfaces (#4946) chore(version): 2024.06.17.0 chore(process_tracker): use `const` instead of `String` for `business_status` (#4849) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When below command is executed in sandbox DB, we get a set of "distinct"
business_status
es that is specified for process tracker:For debugging and fun, execute to learn more about process tracker and its behavior:
The main goal for us here is to keep all the
business_status
es in a single place, confined for ease of access and increased readability. This also helps us keep track of the statuses we use.Additional Changes
Motivation and Context
We need to keep a track of the statuses that we use in
process_tracker
How did you test it?
This should not require any testing as the change done is here just a mere replacement of hardcoded string with
const
s. If needed, the changes can be verified by following #3712's instructions. Reproduced below:Perform PSync call from connector like
Checkout
. Payment Status should go toprocessing
state. Wait forprocess_tracker
to kick in and do aforce_sync
on its own. Wait for the status to get updated. I had webhooks set up (invalid configuration), even that is verified to be working.Command used in DB:
Checklist
cargo +nightly fmt --all
cargo clippy