-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): added amount conversion framework for klarna and change type of amount to MinorUnit for OrderDetailsWithAmount #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiranKBR
changed the title
do-amount-conversion-for-klarna
refactor(connector): added amount conversion framework for klarna
Jun 13, 2024
Base automatically changed from
5188-amount-conversion-do-amount-conversion-for-iatapay
to
main
July 1, 2024 11:36
KiranKBR
force-pushed
the
do-amount-conversion-for-klarna
branch
from
July 17, 2024 13:10
60e988f
to
19d54b0
Compare
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jul 17, 2024
…amount-conversion-for-klarna
KiranKBR
force-pushed
the
do-amount-conversion-for-klarna
branch
from
July 25, 2024 11:26
19a9185
to
bc0a254
Compare
hyperswitch-bot
bot
added
M-api-contract-changes
Metadata: This PR involves API contract changes
and removed
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Jul 25, 2024
KiranKBR
force-pushed
the
do-amount-conversion-for-klarna
branch
from
July 25, 2024 11:56
c882e54
to
5c2ac69
Compare
hyperswitch-bot
bot
removed
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jul 25, 2024
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jul 25, 2024
…juspay/hyperswitch into do-amount-conversion-for-klarna
…juspay/hyperswitch into do-amount-conversion-for-klarna t : ":wq
sahkal
reviewed
Oct 23, 2024
} | ||
} | ||
|
||
impl Sum for MinorUnit { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add is already there why is Sum needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.sum() function is required to accumulate the elements of an iterator for OrderDetails.
sahkal
previously approved these changes
Oct 23, 2024
swangi-kumari
changed the title
refactor(connector): added amount conversion framework for klarna
refactor(connector): added amount conversion framework for klarna and change type of amount to MinorUnit for OrderDetailsWithAmount
Oct 24, 2024
swangi-kumari
force-pushed
the
do-amount-conversion-for-klarna
branch
from
October 24, 2024 13:41
c93a383
to
1adb70a
Compare
SanchithHegde
approved these changes
Oct 24, 2024
sahkal
approved these changes
Oct 24, 2024
deepanshu-iiitu
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Response
Note:
Checklist
cargo +nightly fmt --all
cargo clippy