Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): setup user authentication methods schema and apis #4999
feat(users): setup user authentication methods schema and apis #4999
Changes from 23 commits
397368a
a21f2e9
556f416
b58bfab
8b4c7bc
92dfc93
015d7e7
3dc3295
aa5fbc0
ae64997
bfa2a47
4c40b6c
e5b743d
3180b9e
9ce92a8
25f54b2
7ef506d
d250d78
60905a6
e4d66c5
bf4ef76
257f816
91cd8d2
bbd1c0b
e63a327
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be forced to take
OpenIdProvider
type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be changed to
String
when we will add other cases, where name doesn't come fromOpenIdProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the
owner_id
, in case onOwner::Internal
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove
Internal
, or assign some id (hyperswitch
) if we think we encounter relevant use cases for this.