Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(users): implemented openidconnect #5124

Merged
merged 15 commits into from
Jun 26, 2024
Merged

feat(users): implemented openidconnect #5124

merged 15 commits into from
Jun 26, 2024

Conversation

racnan
Copy link
Contributor

@racnan racnan commented Jun 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Two new apis give

  • generate and redirect to openid provider.
  • signin using data given by openid provider.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Required for users to signin using sso.

How did you test it?

Redirect to sso

curl --location '<BASE URL>/user/auth/url?id=<>'

Signin with sso.

curl --location --request POST '<BASE URL>/user/oidc' \
--header 'Content-Type: application/json' \
--data-raw '{
    "state":"",
    "code": ""
}'

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@racnan racnan added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels Jun 26, 2024
@racnan racnan self-assigned this Jun 26, 2024
@racnan racnan requested review from a team as code owners June 26, 2024 10:33
@racnan racnan linked an issue Jun 26, 2024 that may be closed by this pull request
feat: create redirect and sso login api #5125
Closed
apoorvdixit88
apoorvdixit88 reviewed Jun 26, 2024
View reviewed changes
crates/router/src/core/errors/user.rs Show resolved Hide resolved
crates/router/src/routes/user.rs Outdated Show resolved Hide resolved
crates/router/src/services/openidconnect.rs Outdated Show resolved Hide resolved
ThisIsMani
ThisIsMani reviewed Jun 26, 2024
View reviewed changes
crates/api_models/src/user.rs Show resolved Hide resolved
crates/router/src/core/errors/user.rs Show resolved Hide resolved
crates/router/src/utils/user.rs Outdated Show resolved Hide resolved
crates/api_models/src/user.rs Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 enabled auto-merge June 26, 2024 13:27
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit ce7d0d4 Jun 26, 2024
11 checks passed
@Gnanasundari24 Gnanasundari24 deleted the okta-sso branch June 26, 2024 14:01
pixincreate added a commit that referenced this pull request Jun 28, 2024
@pixincreate
Merge branch 'iatapay-through-hyperswitch-cypress' of github.com:jusp…
426a705 
…ay/hyperswitch into iatapay-through-hyperswitch-cypress

* 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch:
  feat(router): skip apple pay session call if the browser is not Safari (#5136)
  fix(opensearch): show search results only if user has access permission to the index  (#5097)
  chore(version): 2024.06.27.0
  feat(users): add endpoint for terminate auth select (#5135)
  feat(users): implemented openidconnect (#5124)
  feat(router): add payments manual-update api (#5045)
  fix(docs): open-api fix for payment response (#5103)
  refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990)
  feat: realtime user analytics (#5098)
  refactor(connector): added amount conversion framework for cashtocode (#4857)
  feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120)
  refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833)
  fix(connector): [BOA/CYBS] make risk information message optional (#5107)
  chore(version): 2024.06.25.1
  fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118)
  refactor: separate DB queries and HTML creation for payout links (#4967)
  feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087)
  fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105)
  chore(version): 2024.06.25.0
pixincreate added a commit that referenced this pull request Jun 28, 2024
@pixincreate
Merge branch 'iatapay-through-hyperswitch-cypress' of github.com:jusp…
d783bb1 
…ay/hyperswitch into refactor-error-handling-in-cypress

* 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch:
  chore: clean up
  feat(router): skip apple pay session call if the browser is not Safari (#5136)
  fix(opensearch): show search results only if user has access permission to the index  (#5097)
  chore(version): 2024.06.27.0
  feat(users): add endpoint for terminate auth select (#5135)
  feat(users): implemented openidconnect (#5124)
  feat(router): add payments manual-update api (#5045)
  fix(docs): open-api fix for payment response (#5103)
  refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990)
  feat: realtime user analytics (#5098)
  refactor(connector): added amount conversion framework for cashtocode (#4857)
  feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120)
  refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833)
  fix(connector): [BOA/CYBS] make risk information message optional (#5107)
  chore(version): 2024.06.25.1
  fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118)
  refactor: separate DB queries and HTML creation for payout links (#4967)
  feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087)
  fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105)
  chore(version): 2024.06.25.0
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMani ThisIsMani ThisIsMani approved these changes

@apoorvdixit88 apoorvdixit88 apoorvdixit88 approved these changes

@lsampras lsampras lsampras approved these changes

Assignees

@racnan racnan

Labels
A-users Area: Users C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: create redirect and sso login api
6 participants
@racnan @lsampras @apoorvdixit88 @ThisIsMani @SanchithHegde @Gnanasundari24