-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(payments_create): save the customer_id
in payments create
#5262
Merged
likhinbopanna
merged 6 commits into
main
from
5259-bug-retrieve-payment-id-throwing-4xx
Jul 10, 2024
Merged
fix(payments_create): save the customer_id
in payments create
#5262
likhinbopanna
merged 6 commits into
main
from
5259-bug-retrieve-payment-id-throwing-4xx
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hrithikesh026
previously approved these changes
Jul 10, 2024
SanchithHegde
approved these changes
Jul 10, 2024
hrithikesh026
approved these changes
Jul 10, 2024
sai-harsha-vardhan
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In case we receive a 4xx when creating the payment before calling the connector, we do not save the
customer_id
in payment intent. This PR fixes itThis PR also includes changes to ensure that
customer_id
is always taken from both the places in the PaymentsRequest. The rootcustomer_id
andcustomer.id
field.Motivation and Context
How did you test it?
Fails with the error message
customer_id
is updatedChecklist
cargo +nightly fmt --all
cargo clippy