-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): fixed integrity check failures in case of 3ds flow in sync flow #5279
Merged
Gnanasundari24
merged 5 commits into
main
from
5919-bug-integrity-check-failed-for-surcharge-3ds-flow
Jul 12, 2024
Merged
fix(router): fixed integrity check failures in case of 3ds flow in sync flow #5279
Gnanasundari24
merged 5 commits into
main
from
5919-bug-integrity-check-failed-for-surcharge-3ds-flow
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahkal
changed the title
refactor(router): fixed capture bug in sbx
refactor(router): fixed surcharge 3ds flow failure in case of sync flow
Jul 10, 2024
sahkal
changed the title
refactor(router): fixed surcharge 3ds flow failure in case of sync flow
fix(router): fixed surcharge 3ds flow failure in case of sync flow
Jul 10, 2024
sahkal
changed the title
fix(router): fixed surcharge 3ds flow failure in case of sync flow
fix(router): fixed integrity check failures in case of surcharge 3ds flow failure in sync flow
Jul 10, 2024
sahkal
changed the title
fix(router): fixed integrity check failures in case of surcharge 3ds flow failure in sync flow
fix(router): fixed integrity check failures in case of surcharge 3ds flow in sync flow
Jul 10, 2024
sahkal
changed the title
fix(router): fixed integrity check failures in case of surcharge 3ds flow in sync flow
fix(router): fixed integrity check failures in case of 3ds flow in sync flow
Jul 11, 2024
sahkal
added
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 11, 2024
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be inline
hrithikesh026
previously approved these changes
Jul 11, 2024
SanchithHegde
approved these changes
Jul 11, 2024
Narayanbhat166
approved these changes
Jul 11, 2024
AkshayaFoiger
approved these changes
Jul 11, 2024
14 tasks
Gnanasundari24
deleted the
5919-bug-integrity-check-failed-for-surcharge-3ds-flow
branch
July 12, 2024 00:04
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
we have implemented integrity checks for stripe, we have implemented integrity in authorise, sync, capture and refund, refund sync
but, where in sync flow we check amount, currency and amount_captured.
the bug is in 3ds flow, where after the transaction is completed we do a sync with the connector, but our trackers are not updated at this point.
In 3ds transaction we rely on connector sync to update our trackers, since integrity checks happens with data before post update trackers we were comparing MinorUnit(0) our amount captured to Some(MinorUnit(x)) amount received by the connector.
due, to this there was a data mismatch issue, which led to integrity check failure.
How did you test it?
Do, 3ds transaction with stripe it should pass.
Screen.Recording.2024-07-11.at.1.57.53.PM.mov
Checklist
cargo +nightly fmt --all
cargo clippy