Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): fail refund with bad request error for duplicate refund_id in refunds create flow #5282

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(router): fail refund with bad request error for duplicate refund_id in refunds create flow #5282

merged 1 commit into from
Jul 11, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fail refund with bad request error for duplicate refund_id in refunds create flow

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
Create a refund with duplicate refund_id, it should fail with Bad request error
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug labels Jul 11, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the July 2024 Release milestone Jul 11, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jul 11, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner July 11, 2024 07:10
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit f63a678 Jul 11, 2024
16 of 17 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-refunds-idempotency-issue branch July 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@sahkal sahkal sahkal approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
July 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-harsha-vardhan @sahkal @Narayanbhat166 @Gnanasundari24