-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(merchant_account): change primary key for merchant account #5327
Merged
Gnanasundari24
merged 12 commits into
main
from
5970-rfactor-remove-id-dependency-from-merchant_account
Jul 18, 2024
Merged
refactor(merchant_account): change primary key for merchant account #5327
Gnanasundari24
merged 12 commits into
main
from
5970-rfactor-remove-id-dependency-from-merchant_account
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 15, 2024
Narayanbhat166
changed the base branch from
main
to
create-justfile-for-running-v2-migrations
July 15, 2024 16:38
…actor-remove-id-dependency-from-merchant_account
SanchithHegde
previously approved these changes
Jul 15, 2024
jarnura
requested changes
Jul 16, 2024
migrations/2024-07-15-111327_change_primary_key_for_merchant_account/up.sql
Show resolved
Hide resolved
Base automatically changed from
create-justfile-for-running-v2-migrations
to
main
July 16, 2024 12:21
Gnanasundari24
dismissed
SanchithHegde’s stale review
July 16, 2024 12:21
The base branch was changed.
SanchithHegde
approved these changes
Jul 17, 2024
jarnura
approved these changes
Jul 18, 2024
Gnanasundari24
deleted the
5970-rfactor-remove-id-dependency-from-merchant_account
branch
July 18, 2024 10:04
pixincreate
added a commit
that referenced
this pull request
Jul 19, 2024
* 'main' of github.com:juspay/hyperswitch: (26 commits) refactor(core): change primary keys in user, user_roles and roles tables (#5374) chore(version): 2024.07.19.1 refactor(connector): make the `original_authorized_amount` optional for MITs with `connector_mandate_details` (#5311) feat(connector): Plaid connector Integration (#3952) feat: encryption service integration to support batch encryption and decryption (#5164) refactor(core): change primary key of refund table (#5367) chore(version): 2024.07.19.0 chore(postman): update Postman collection files Docs: Updating Error codes for documentation purposes (#5314) fix(core): [payouts] failure of payout retrieve when token is expired (#5362) build: remove unused dependencies (#5343) refactor(blocklist): change primary key of blocklist table (#5356) chore: Increasing log coverage for payment method list (#5042) refactor(routing): Remove backwards compatibility for the routing crate (#3015) refactor(merchant_account): change primary key for merchant account (#5327) refactor(router): remove id dependency from merchant connector account, dispute and mandate (#5330) feat(connector): [Itau Bank] Template for payment flows (#5304) chore(version): 2024.07.18.0 refactor(router): Remove the locker call in the psync flow (#5348) feat(router): Add support for passing the domain dynamically in the session call (#5347) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR changes the primary key of
merchant_account
from id tomerchant_id
.It also adds back id in payment intent and attempt which were dropped as part of v2 migrations.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy