feat(connector): [Itau Bank] Add payment and sync flow for Pix #5342

Sakilmostak · 2024-07-16T19:44:49Z

Type of Change

Description

Add payment and sync flow for Itau Bank connector

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Through Cypress:

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

srujanchikke · 2024-07-18T11:37:18Z

crates/router/src/connector/itaubank/transformers.rs

+                        })
+                    }
+                    _ => Err(
+                        errors::ConnectorError::NotImplemented("Payment methods".to_string())


Suggested change

errors::ConnectorError::NotImplemented("Payment methods".to_string())

errors::ConnectorError::NotImplemented("Payment method".to_string())

srujanchikke · 2024-07-18T11:41:28Z

crates/router/src/connector/itaubank/transformers.rs

+                            devedor,
+                        })
+                    }
+                    _ => Err(


can we not use _=> instead do a match on all payment method types?

SamraatBansal

Please add cypress test cases

SamraatBansal · 2024-07-19T08:08:06Z

crates/router/src/connector/itaubank.rs

+        ),
+        (
+            headers::USER_AGENT.to_string(),
+            "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36".to_string().into(),


Should not be hard_coded, can take this from browser_info, if a required field

SamraatBansal · 2024-07-19T08:08:30Z

crates/router/src/connector/itaubank.rs

+        ),
+        (
+            headers::ACCEPT.to_string(),
+            "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.".to_string().into(),


Does all these types are required to mentioned?

crates/hyperswitch_domain_models/src/payment_method_data.rs

crates/api_models/src/payments.rs

SanchithHegde · 2024-07-22T09:16:40Z

crates/router/src/connector/itaubank.rs

+        ),
+        (
+            headers::ACCEPT.to_string(),
+            "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.".to_string().into(),


We probably don't need all these types. And this doesn't seem to have JSON included here?

SanchithHegde · 2024-07-22T09:33:12Z

crates/hyperswitch_domain_models/src/router_request_types.rs

@@ -414,6 +414,7 @@ pub struct PaymentsSyncData {
    pub payment_method_type: Option<storage_enums::PaymentMethodType>,
    pub currency: storage_enums::Currency,
    pub payment_experience: Option<common_enums::PaymentExperience>,
+    pub browser_info: Option<BrowserInformation>,


Let's not use this browser information object, let's hard-code the user agent instead.

CC: @Narayanbhat166

Yes, we should attach the user agent of our reqwest client here and not the one that we receive from the user

SanchithHegde · 2024-07-22T09:34:05Z

crates/router/src/connector/itaubank.rs

+        let req = Some(
+            services::RequestBuilder::new()
+                .method(services::Method::Post)
+                .headers(types::RefreshTokenType::get_headers(self, req, connectors)?)


Can we attach default headers as well?

SanchithHegde · 2024-07-22T10:11:05Z

crates/router/src/connector/itaubank.rs

    ) -> CustomResult<String, errors::ConnectorError> {
-        Err(errors::ConnectorError::NotImplemented("get_url method".to_string()).into())
+        Ok(format!(
+            "{}itau-ep9-gtw-pix-recebimentos-ext-v2/v2/cob",


Hard-coding this part of the URL can require us significant build time if and when we are required to update this URL. Can we have this part of the URL being read from configs?

pixincreate · 2024-07-22T10:24:44Z

cypress-tests/cypress/e2e/PaymentUtils/ItauBank.js

+    card_pm: {
+        ZeroAuthMandate: {
+            Response: {
+              status: 500,


Is this intentional? 4xx is expected here if I'm not wrong. Also, this can be picked from defaults which is in commons.js

pixincreate · 2024-07-22T10:25:54Z

cypress-tests/cypress/e2e/PaymentUtils/ItauBank.js

+                country_code: "+91",
+              },
+            },
+            currency: "BRL",


Since currency is passed in payment intent, this can be removed.

pixincreate · 2024-07-22T10:29:35Z

cypress-tests/cypress/support/redirectionHandler.js

+                break;
+              default:
+                verifyReturnUrl(redirection_url, expected_url, true);
+              // expected_redirection can be used here to handle other payment methods


please check the lints

pixincreate · 2024-07-22T10:30:02Z

cypress-tests/cypress/support/redirectionHandler.js

+          switch (payment_method_type) {
+            case "pix":
+              fetchAndParseImageData(redirection_url).then((qrCodeData) => {
+                console.log("Imaage_data>>>>>>>>>", qrCodeData)


console.log() can be removed as it is no longer necessary.

Since these are minor changes, Im putting them in the subsequent pr for refund

* 'main' of github.com:juspay/hyperswitch: (27 commits) refactor(connector): added amount conversion framework for billwerk (#4972) feat(connector): [Itaubank] Add refund and rsync flow (#5420) feat: create additional columns in organization table (#5380) refactor(merchant_id): create domain type for `merchant_id` (#5408) fix(euclid): remove business_profile routing feature flag (#5430) feat: add create retrieve and update api endpoints for organization resource (#5361) chore(version): 2024.07.24.0 refactor(connector): [Itaubank] add dynamic fields for pix (#5419) Feat(connector): [WELLSFARGO] Add template code (#5333) fix(connector): [Datatrans] Handling for 4-Digit YYYY input and Correct 3DS Routing to no_3ds (#5410) refactor(connector): add amount conversion framework to volt (#4985) chore(users): email templates footer icon style enhance (#5375) feat(customer): customer v2 refactor for customer create end point (#5350) chore(version): 2024.07.23.0 fix(router): store `network_transaction_id` in stripe `authorize` flow (#5399) ci: handle packages to run are being empty (#5403) chore: add customer, shipping and billing details to payment_response for payment list api (#5401) refactor(dashboard_metadata): alter query for merchant scoped metadata (#5397) refactor(connector): Add billing_country in klarna dynamic fields (#5373) feat(connector): [Itau Bank] Add payment and sync flow for Pix (#5342) ...

Sakilmostak added 7 commits July 12, 2024 01:29

feat: template for itau bank

f56dc64

refactor: add itaubank in connector

ab82929

feat: add payment flow for pix

49a3dd8

refactor: pix qr code flow

6f087c5

refactor: base_url

c579d78

feat: add sync flow

c6cd5fb

refactor: handle error response

93b3914

Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Jul 16, 2024

Sakilmostak added this to the July 2024 Release milestone Jul 16, 2024

Sakilmostak self-assigned this Jul 16, 2024

Sakilmostak requested review from a team as code owners July 16, 2024 19:44

Sakilmostak added 3 commits July 17, 2024 01:20

Merge branch 'main' into itau_bank

a76e9c7

refactor: merge main

759b769

refactor: openapi spec generation

f73cf53

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jul 17, 2024

refactor: add wasm and producton base url

4010d72

Sakilmostak changed the base branch from main to itau_template July 17, 2024 08:48

Sakilmostak requested review from a team as code owners July 17, 2024 08:48

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Jul 17, 2024

Sakilmostak changed the base branch from itau_template to main July 17, 2024 08:48

hyperswitch-bot bot removed the M-database-changes Metadata: This PR involves database schema changes label Jul 17, 2024

Sakilmostak removed the request for review from a team July 17, 2024 08:49

Merge branch 'main' into itau_bank

f546f53

srujanchikke reviewed Jul 18, 2024

View reviewed changes

refactor: resolve comments

770d8c2

srujanchikke previously approved these changes Jul 18, 2024

View reviewed changes

SamraatBansal requested changes Jul 19, 2024

View reviewed changes

pixincreate added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 19, 2024

refactor: resolve comments

b2d1cb0

Sakilmostak dismissed srujanchikke’s stale review via b2d1cb0 July 19, 2024 12:01

Sakilmostak added 2 commits July 21, 2024 23:49

feat: add cypress text

7c43d67

Merge branch 'main' into itau_bank

9c040aa

Sakilmostak removed the request for review from a team July 22, 2024 06:32

SamraatBansal requested changes Jul 22, 2024

View reviewed changes

crates/api_models/src/payments.rs Show resolved Hide resolved

SamraatBansal approved these changes Jul 22, 2024

View reviewed changes

srujanchikke approved these changes Jul 22, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Jul 22, 2024

View reviewed changes

SanchithHegde requested a review from Narayanbhat166 July 22, 2024 07:51

SanchithHegde approved these changes Jul 22, 2024

View reviewed changes

SanchithHegde requested a review from a team July 22, 2024 10:20

likhinbopanna approved these changes Jul 22, 2024

View reviewed changes

likhinbopanna added this pull request to the merge queue Jul 22, 2024

pixincreate reviewed Jul 22, 2024

View reviewed changes

pixincreate removed this pull request from the merge queue due to a manual request Jul 22, 2024

pixincreate added this pull request to the merge queue Jul 22, 2024

Merged via the queue into main with commit 3fef96e Jul 22, 2024
13 checks passed

pixincreate deleted the itau_bank branch July 22, 2024 11:00

pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 22, 2024

Sakilmostak added a commit that referenced this pull request Jul 22, 2024

feat(connector): [Itau Bank] Add payment and sync flow for Pix (#5342)

864047e

Sakilmostak mentioned this pull request Jul 22, 2024

feat(connector): [Itau Bank] Add payment and sync flow for Pix #5405

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Itau Bank] Add payment and sync flow for Pix #5342

feat(connector): [Itau Bank] Add payment and sync flow for Pix #5342

Sakilmostak commented Jul 16, 2024 •

edited

Loading

srujanchikke Jul 18, 2024

srujanchikke Jul 18, 2024

SamraatBansal left a comment

SamraatBansal Jul 19, 2024

SamraatBansal Jul 19, 2024

SanchithHegde Jul 22, 2024

SanchithHegde Jul 22, 2024

Narayanbhat166 Jul 22, 2024

SanchithHegde Jul 22, 2024

SanchithHegde Jul 22, 2024

pixincreate Jul 22, 2024

pixincreate Jul 22, 2024

pixincreate Jul 22, 2024

pixincreate Jul 22, 2024

Sakilmostak Jul 22, 2024

	errors::ConnectorError::NotImplemented("Payment methods".to_string())
	errors::ConnectorError::NotImplemented("Payment method".to_string())

feat(connector): [Itau Bank] Add payment and sync flow for Pix #5342

feat(connector): [Itau Bank] Add payment and sync flow for Pix #5342

Conversation

Sakilmostak commented Jul 16, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamraatBansal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakilmostak commented Jul 16, 2024 •

edited

Loading