-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add offset and limit to key transfer API #5358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jul 18, 2024
NishantJoshi00
requested changes
Jul 18, 2024
ArjunKarthik
previously approved these changes
Jul 18, 2024
NishantJoshi00
previously approved these changes
Jul 18, 2024
lsampras
reviewed
Jul 18, 2024
ThisIsMani
previously approved these changes
Jul 18, 2024
dracarys18
dismissed stale reviews from ThisIsMani, NishantJoshi00, and ArjunKarthik
via
July 19, 2024 07:29
11eab9d
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 19, 2024
dracarys18
force-pushed
the
add_offset_to_transfer_key
branch
from
July 19, 2024 07:32
11630c5
to
12340c8
Compare
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 19, 2024
ArjunKarthik
previously approved these changes
Jul 22, 2024
ThisIsMani
previously approved these changes
Jul 22, 2024
vspecky
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…witch into add_offset_to_transfer_key
dracarys18
dismissed stale reviews from vspecky, ThisIsMani, and ArjunKarthik
via
July 22, 2024 08:49
1b41b4d
lsampras
approved these changes
Jul 22, 2024
vspecky
approved these changes
Jul 22, 2024
ArjunKarthik
approved these changes
Jul 22, 2024
ThisIsMani
approved these changes
Jul 22, 2024
NishantJoshi00
approved these changes
Jul 22, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add offset and limit to key transfer API
Motivation and Context
This adds
from
andlimit
parameters to Key transfer API and thus providing a way to transfer the keys in batches.How did you test it?
/accounts/transfer
withfrom
andlimit
parameters. It should respond with thetotal_transferred
same aslimit
.user/key/transfer
Checklist
cargo +nightly fmt --all
cargo clippy