fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licitly for open payment links
sahkal
approved these changes
Aug 1, 2024
AkshayaFoiger
approved these changes
Aug 1, 2024
2 tasks
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
…ypress-x2 * 'main' of github.com:juspay/hyperswitch: refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488)
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds an argument to be sent to the SDK for open payment links. This field controls the listing of SPMs for a given customer. Default value is
truein SDK, needs to be sent asfalseexplicitly during SDK integrationAdditional Changes
Motivation and Context
Bug fixes; open link is not behaving as expected
How did you test it?
1. Create non 3DS open payment link with an existing customer
curl --location 'https://sandbox.hyperswitch.io/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY' \ --data-raw '{ "customer_id": "cus_05845u0qSuOENDnHLqTl", "amount": 100, "currency": "USD", "payment_link": true, "authentication_type": "no_three_ds", "connector": [ "stripe" ], "billing": { "address": { "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "CA", "zip": "94122", "country": "US", "first_name": "John", "last_name": "Doe" }, "phone": { "number": "8056594427", "country_code": "+91" } }, "email": "john.doe@example.com", "session_expiry": 1000000, "return_url": "https://google.com", "payment_link_config": { "theme": "#14356f", "logo": "https://hyperswitch.io/favicon.ico", "seller_name": "HyperSwitch Inc." } }'SPMs should not be displayed in the payment link
Checklist
cargo +nightly fmt --allcargo clippy