refactor(core): Refactor fallback routing behaviour in payments for v2 #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarnura
requested changes
Aug 20, 2024
…into fallback-core
…into fallback-core
2 tasks
jarnura
previously approved these changes
Aug 21, 2024
kashif-m
reviewed
Aug 22, 2024
kashif-m
approved these changes
Aug 22, 2024
Narayanbhat166
approved these changes
Aug 22, 2024
jarnura
approved these changes
Aug 22, 2024
prajjwalkumar17
approved these changes
Aug 22, 2024
pixincreate
added a commit
that referenced
this pull request
Aug 23, 2024
* 'main' of github.com:juspay/hyperswitch: feat(connector): [Adyen] add dispute flows for adyen connector (#5514) chore(version): 2024.08.23.0 feat(router): [cybersource] add disable_avs and disable_cvn flag in connector metadata (#5667) feat(customer_v2): add route for customer retrieve v2 (#5516) chore(version): 2024.08.22.1 fix(router): [Adyen] prevent partial submission of billing address and add required fields for all payment methods (#5660) docs(README): Adding Contributors guide (#5184) Docs: Adding redirect url details (#5507) feat(global_id): create a `GlobalId` domain type (#5644) feat(router): collect customer address details based on business profile config regardless of connector required fields (#5418) feat: add new routes for profile level list apis (#5589) refactor(core): Refactor fallback routing behaviour in payments for v2 (#5642) refactor(router): add connector_transaction_id, send response body and use admin_api_auth_with_merchant_id for payments manual update flow (#5658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR refactors the fallback routing behaviour in payments routing for v2. Update the function to accept business_profile as a parameter instead of profile_id.
Additional Changes
Motivation and Context
How did you test it?
For v2:
Checklist
cargo +nightly fmt --allcargo clippy