Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump diesel to 2.2.3 and sqlx to 0.8.1 #5688

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR updates diesel to 2.2.3, sqlx to 0.8.1 and bigdecimal to 0.4.5. diesel 2.2.3 requires an MSRV of 1.78, and sqlx 0.8.1 requires an MSRV of 1.80 (at least until launchbadge/sqlx#3459 is merged and a new version is released), so the MSRV had to be bumped to 1.80.

In addition, this PR removes the dependency on the bigdecimal crate in router and replaces it with num-traits, since we were only using a trait from num-traits re-exported by bigdecimal.

Motivation and Context

The updated versions of the dependencies address security vulnerabilities GHSA-xmrp-424f-vfpx and GHSA-wq9x-qwcq-mmgf.

How did you test it?

N/A

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@SanchithHegde SanchithHegde added A-dependencies Area: Dependencies S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 25, 2024
@SanchithHegde SanchithHegde added this to the August 2024 Release milestone Aug 25, 2024
@SanchithHegde SanchithHegde self-assigned this Aug 25, 2024
@SanchithHegde SanchithHegde requested review from a team as code owners August 25, 2024 15:13
Copy link

semanticdiff-com bot commented Aug 25, 2024

Review changes with SemanticDiff.

Analyzed 4 of 18 files.

Overall, the semantic diff is 22% smaller than the GitHub diff.

Filename Status
.deepsource.toml Unsupported file format
Cargo.lock Unsupported file format
Cargo.toml Unsupported file format
INSTALL_dependencies.sh Unsupported file format
crates/storage_impl/Cargo.toml Unsupported file format
crates/router_derive/Cargo.toml Unsupported file format
crates/router/Cargo.toml Unsupported file format
✔️ crates/router/src/services/kafka.rs Analyzed
✔️ crates/router/src/connector/signifyd/transformers/api.rs Analyzed
crates/masking/Cargo.toml Unsupported file format
crates/hsdev/Cargo.toml Unsupported file format
crates/drainer/Cargo.toml Unsupported file format
crates/diesel_models/Cargo.toml Unsupported file format
crates/common_utils/Cargo.toml Unsupported file format
crates/common_enums/Cargo.toml Unsupported file format
crates/analytics/Cargo.toml Unsupported file format
✔️ crates/analytics/src/sqlx.rs 86.67% smaller
✔️ api-reference-v2/openapi_spec.json Analyzed

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 25, 2024
@SanchithHegde SanchithHegde force-pushed the dep-update-diesel-2.2.3-sqlx-0.8.1 branch from a462ba4 to 1117bdb Compare August 25, 2024 15:19
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 138134d Aug 26, 2024
14 checks passed
@likhinbopanna likhinbopanna deleted the dep-update-diesel-2.2.3-sqlx-0.8.1 branch August 26, 2024 13:53
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 26, 2024
pixincreate added a commit that referenced this pull request Aug 27, 2024
* 'main' of github.com:juspay/hyperswitch:
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
pixincreate added a commit that referenced this pull request Aug 27, 2024
* 'main' of github.com:juspay/hyperswitch: (134 commits)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
  feat(connector): [Adyen] add dispute flows for adyen connector (#5514)
  chore(version): 2024.08.23.0
  ...
pixincreate added a commit that referenced this pull request Aug 27, 2024
…-key-check

* 'main' of github.com:juspay/hyperswitch:
  feat(core): Add mTLS certificates for each request (#5636)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
@SanchithHegde SanchithHegde mentioned this pull request Sep 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants