fix(cypress): fix cypress throwing error when connectorId is not passed and miscellaneous fixes
#5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
requested review from
Sakilmostak,
Gnanasundari24 and
likhinbopanna
|
Review changes with SemanticDiff. Analyzed 6 of 6 files. Overall, the semantic diff is 96% smaller than the GitHub diff. 1 files do not contain logic changes.
|
likhinbopanna
previously approved these changes
Aug 30, 2024
… create call" This reverts commit f714f22.
likhinbopanna
previously approved these changes
Aug 30, 2024
Sakilmostak
approved these changes
Aug 31, 2024
likhinbopanna
approved these changes
Sep 2, 2024
Gnanasundari24
approved these changes
Sep 2, 2024
pixincreate
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Sep 3, 2024
…config-fix * 'main' of github.com:juspay/hyperswitch: feat: add profile_id authentication for business profile update and list (#5673) chore(version): 2024.09.03.0 feat(user): implement invitations api (#5769) feat(connector): [Adyenplatform] add webhooks for payout (#5749) refactor(v2_migrations): re-organize v2 migrations (#5760) chore: add wasm support for connector additional details (#5712) refactor(connector): Move globepay, powertranz, tsys, worldline to hyperswitch_connectors (#5758) fix(cypress): fix cypress throwing error when `connectorId` is not passed and miscellaneous fixes (#5746) chore: fix typos (#5766) refactor(business_profile): change id for business profile (#5748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
connectorIdisundefined. This would occur whenroutingandpayment method listtests were being run directly without passing theconnectorIdwhich is in fact redundantreports, we now passserviceas prefix without which it takesundefinedas connector name which is not intended and for CI, reportName is considered fromenvroutingtest by removingshould_continueflag where Cypress would throw an error stating it to be not definedconnectorIdinglobalStateduring connector create call to address occasional unintended issues where it would not get updated properlyv13.14.0fromv13.13.3Note
Changes have been split into different commits for ease of reviewing.
Additional Changes
Motivation and Context
NIL
How did you test it?
npm run cypress:payment-method-listnpm run cypress:routingNote
Routing tests now throw one less error.
PML and Routing tests now run without user needing to pass
CYPRESS_CONNECTORasenvChecklist
prettier . --writecargo clippy