Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): add card_network as a field in payment_attempts clickhouse table #5807

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat(analytics): add card_network as a field in payment_attempts clickhouse table #5807

merged 2 commits into from
Sep 10, 2024

Conversation

tsdk02
Copy link
Contributor

@tsdk02 tsdk02 commented Sep 5, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added card_network as a field in payment_attempts clickhouse table

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Made sample payments on sandbox dashboard and confirmed the data for card_network on clickhouse sandbox
image
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@tsdk02 tsdk02 self-assigned this Sep 5, 2024
@tsdk02 tsdk02 requested a review from a team as a code owner September 5, 2024 08:24
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@tsdk02 tsdk02 linked an issue Sep 5, 2024 that may be closed by this pull request
feat(analytics): add card_network as a field in clickhouse payment_attempts table #5806
Closed
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit bf1797f Sep 10, 2024
22 checks passed
@Gnanasundari24 Gnanasundari24 deleted the update_clickhouse_scripts branch September 10, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racnan racnan racnan approved these changes

@lsampras lsampras lsampras approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@tsdk02 tsdk02

Labels
A-Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(analytics): add card_network as a field in clickhouse payment_attempts table
4 participants
@tsdk02 @lsampras @racnan @Gnanasundari24