fix: fix status_code being logged as string instead of number in logs

[SanchithHegde]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

This PR fixes a bug with the status_code field being logged as a string instead of a number in JSON logs. This was primarily happening in two functions: router::services::api::call_connector_api() and router::core::webhooks::outgoing::error_response_handler().

The bug occurred due to the Debug implementation of the field being used to log the values (with the ? sigil). Using the % sigil to use the Display implementation to log the status code also caused the same problem. The fix was to not provide any sigil (? or %) and let tracing automatically format the status code.

Motivation and Context

This PR fixes a bug with status codes being sometimes logged as strings, which also caused issues with Elasticsearch being unable to index the field correctly.

How did you test it?

1. Create a successful payment using Postman (basically any request that includes a connector call).

2. Search logs, filtering by the request ID and searching for call_connector_api.

   Previously, the status code was logged as a string:

   

   With this fix, the status code is correctly logged as a number:

   

   As part of this change, the url field in the log message also loses one set of double quotes (and is no longer escaped as a result).

3. If the webhook URL is configured incorrectly in the business profile (such that the URL returns a non-2xx status code when a webhook is sent) and the payment created triggers a webhook, then the error log should also have the status code logged as a number (logs can be filtered with request ID and the message Ignoring error when sending webhook to merchant):

   Before:

   

   After:

   

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

	Filename	Status
✔️	crates/router/src/services/api.rs	Analyzed
✔️	crates/router/src/core/webhooks/outgoing.rs	Analyzed