-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Novalnet] add Recurring payment flow for cards #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 20% smaller than the GitHub diff.
|
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
from
September 17, 2024 09:36
6d66813
to
97c87dc
Compare
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
from
September 17, 2024 09:51
97c87dc
to
9af2865
Compare
cookieg13
changed the title
Novalnet recurring payments
feat(connector): [Novalnet] add Recurring payment flow for cards
Sep 17, 2024
cookieg13
added
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Sep 17, 2024
srujanchikke
requested changes
Sep 17, 2024
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
from
September 17, 2024 13:42
e6e2f03
to
ebdfa80
Compare
srujanchikke
previously approved these changes
Sep 17, 2024
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
from
September 18, 2024 09:39
ebdfa80
to
059908b
Compare
deepanshu-iiitu
requested changes
Sep 18, 2024
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
previously approved these changes
Sep 18, 2024
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
3 times, most recently
from
September 19, 2024 07:23
5944263
to
ff2dcff
Compare
cookieg13
force-pushed
the
novalnetRecurringPayments
branch
from
September 19, 2024 09:20
ff2dcff
to
3130d94
Compare
srujanchikke
approved these changes
Sep 19, 2024
deepanshu-iiitu
approved these changes
Sep 19, 2024
SanchithHegde
approved these changes
Sep 19, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implemented Card Mandates for Novalnet (3DS)
Additional Changes
Motivation and Context
How did you test it?
Could not run cypress tests since we don't have support for 3ds mandates cypress tests. cc: @likhinbopanna
Create Call CIT
Confirm Call CIT
Confirm Response CIT
MIT Call
MIT Response
Checklist
cargo +nightly fmt --all
cargo clippy